Skip to content

Commit 5bdfa75

Browse files
refactor(signing): remove redundant MISSING toggle fallback
After moving the missing-CDP policy decision to AEngineHandler, Password no longer needs to re-check app config for MISSING. Keep only status-based validation in validateCertificateRevocation. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
1 parent 0ea77a2 commit 5bdfa75

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

lib/Service/IdentifyMethod/SignatureMethod/Password.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
namespace OCA\Libresign\Service\IdentifyMethod\SignatureMethod;
1010

11-
use OCA\Libresign\AppInfo\Application;
1211
use OCA\Libresign\Enum\CrlValidationStatus;
1312
use OCA\Libresign\Exception\InvalidPasswordException;
1413
use OCA\Libresign\Exception\LibresignException;
@@ -60,12 +59,6 @@ private function validateCertificateRevocation(array $certificateData): void {
6059
if ($status === CrlValidationStatus::DISABLED) {
6160
return;
6261
}
63-
// MISSING is set before the CRL checker runs (no CDP extension at all), so
64-
// the toggle is not consulted by the checker. Check it explicitly here.
65-
if ($status === CrlValidationStatus::MISSING
66-
&& !$this->identifyService->getAppConfig()->getValueBool(Application::APP_ID, 'crl_external_validation_enabled', true)) {
67-
return;
68-
}
6962
throw new LibresignException($this->getRevocationErrorMessage($status), 422);
7063
}
7164

0 commit comments

Comments
 (0)