Merge pull request #7282 from LibreSign/backport/7280/stable33

[stable33] test: avoid async hook imports in request signature tab spec

Author: vitormattos

src/tests/components/LeftSidebar/LeftSidebar.spec.ts

@@ -3,9 +3,10 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import { beforeAll, beforeEach, describe, expect, it, vi } from 'vitest'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { createL10nMock } from '../../testHelpers/l10n.js'
 import { mount } from '@vue/test-utils'
+import LeftSidebar from '../../../components/LeftSidebar/LeftSidebar.vue'
 
 const loadStateMock = vi.fn()
 const getCurrentUserMock = vi.fn()
@@ -27,12 +28,6 @@ vi.mock('../../../store/files.js', () => ({
 	}),
 }))
 
-let LeftSidebar: unknown
-
-beforeAll(async () => {
-	;({ default: LeftSidebar } = await import('../../../components/LeftSidebar/LeftSidebar.vue'))
-})
-
 describe('LeftSidebar', () => {
 	beforeEach(() => {
 		loadStateMock.mockReset()
@@ -53,7 +48,7 @@ describe('LeftSidebar', () => {
 		})
 		getCurrentUserMock.mockReturnValue({ isAdmin: true })
 
-		const wrapper = mount(LeftSidebar as never, {
+		const wrapper = mount(LeftSidebar, {
 			global: {
 				stubs: {
 					NcAppNavigation: {

src/tests/components/RightSidebar/RequestSignatureTab.spec.ts

@@ -3,14 +3,14 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import { beforeAll, beforeEach, describe, expect, it, vi } from 'vitest'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { shallowMount } from '@vue/test-utils'
 import type { VueWrapper } from '@vue/test-utils'
 import { createPinia, setActivePinia } from 'pinia'
 import axios from '@nextcloud/axios'
 import type { useFilesStore as useFilesStoreType } from '../../../store/files.js'
-let RequestSignatureTab: unknown
-let useFilesStore: typeof import('../../../store/files.js').useFilesStore
+import RequestSignatureTab from '../../../components/RightSidebar/RequestSignatureTab.vue'
+import { useFilesStore } from '../../../store/files.js'
 import { FILE_STATUS } from '../../../constants.js'
 
 const { generateUrlMock } = vi.hoisted(() => ({
@@ -80,11 +80,6 @@ describe('RequestSignatureTab - Critical Business Rules', () => {
 	let wrapper: VueWrapper<any>
 	let filesStore: ReturnType<typeof useFilesStoreType>
 
-	beforeAll(async () => {
-		RequestSignatureTab = (await import('../../../components/RightSidebar/RequestSignatureTab.vue')).default
-		;({ useFilesStore } = await import('../../../store/files.js'))
-	})
-
 	const updateFile = async (patch: Record<string, unknown>) => {
 		const current = filesStore.files[1] || { id: 1 }
 		const hasSigners = Object.prototype.hasOwnProperty.call(patch, 'signers')

src/tests/components/Signers/Signer.spec.ts

@@ -3,18 +3,17 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import { beforeAll, beforeEach, describe, expect, it, vi } from 'vitest'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { createL10nMock } from '../../testHelpers/l10n.js'
 import type { MockedFunction } from 'vitest'
 import { mount } from '@vue/test-utils'
 import type { VueWrapper } from '@vue/test-utils'
 import { createPinia, setActivePinia } from 'pinia'
 import { mdiCheckCircle, mdiClockOutline, mdiCircleOutline } from '@mdi/js'
 import type { TranslationFunction, PluralTranslationFunction } from '../../test-types'
+import Signer from '../../../components/Signers/Signer.vue'
 import { useFilesStore } from '../../../store/files.js'
 
-type SignerComponent = typeof import('../../../components/Signers/Signer.vue').default
-
 type FileSigner = {
 	signed?: boolean
 	identifyMethods?: Array<{ method: string }>
@@ -67,8 +66,6 @@ const { t, n } = vi.hoisted(() => {
 	return { t, n }
 })
 
-let Signer: SignerComponent
-
 vi.mock('@nextcloud/initial-state', () => ({
 	loadState: vi.fn((app, key, defaultValue) => {
 		if (key === 'can_request_sign') return true
@@ -89,10 +86,6 @@ vi.mock('@nextcloud/l10n', () => createL10nMock())
 
 import { emit } from '@nextcloud/event-bus'
 
-beforeAll(async () => {
-	;({ default: Signer } = await import('../../../components/Signers/Signer.vue'))
-})
-
 describe('Signer', () => {
 	let wrapper: SignerWrapper | null
 	let filesStore: FilesStoreMock

src/tests/components/Signers/Signers.spec.ts

@@ -3,13 +3,12 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import { beforeAll, beforeEach, describe, expect, it, vi } from 'vitest'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { shallowMount } from '@vue/test-utils'
 import type { VueWrapper } from '@vue/test-utils'
 import { createPinia, setActivePinia } from 'pinia'
 import type { Pinia } from 'pinia'
-type SignersComponent = typeof import('../../../components/Signers/Signers.vue').default
-let Signers: SignersComponent
+import Signers from '../../../components/Signers/Signers.vue'
 import { useFilesStore } from '../../../store/files.js'
 import type { SignatureFlowValue } from '../../../types/index'
 
@@ -49,10 +48,6 @@ vi.mock('@nextcloud/initial-state', () => ({
 	loadState: vi.fn(),
 }))
 
-beforeAll(async () => {
-	;({ default: Signers } = await import('../../../components/Signers/Signers.vue'))
-})
-
 
 describe('Signers', () => {
 	let wrapper: SignersWrapper | null