refactor: remove unnecessary nullable type from Password

vitormattos · backportbot-libresign[bot] · commit 49c510c6d6f0 · 2026-04-04T17:51:50.000Z
- getRevocationErrorMessage() now accepts non-nullable CrlValidationStatus
- Status is always present and typed as enum (never null) from CrlRevocationChecker
- Reflects contract that certificate data always has validated CRL status

Signed-off-by: Vitor Mattos &lt;1079143+vitormattos@users.noreply.github.com&gt;
diff --git a/lib/Service/IdentifyMethod/SignatureMethod/Password.php b/lib/Service/IdentifyMethod/SignatureMethod/Password.php
@@ -70,7 +70,7 @@ private function logRevocationBlockedSigning(CrlValidationStatus $status): void
 		]);
 	}
 
-	private function getRevocationErrorMessage(?CrlValidationStatus $status): string {
+	private function getRevocationErrorMessage(CrlValidationStatus $status): string {
 		return match ($status) {
 			CrlValidationStatus::URLS_INACCESSIBLE => $this->identifyService->getL10n()->t('Cannot reach the certificate revocation service. Signing is not allowed.'),
 			CrlValidationStatus::VALIDATION_ERROR => $this->identifyService->getL10n()->t('An error occurred during certificate validation. Signing is not allowed.'),

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ private function logRevocationBlockedSigning(CrlValidationStatus $status): void`
`70`	`70`	`]);`
`71`	`71`	`}`
`72`	`72`
`73`		`- private function getRevocationErrorMessage(?CrlValidationStatus $status): string {`
	`73`	`+ private function getRevocationErrorMessage(CrlValidationStatus $status): string {`
`74`	`74`	`return match ($status) {`
`75`	`75`	`CrlValidationStatus::URLS_INACCESSIBLE => $this->identifyService->getL10n()->t('Cannot reach the certificate revocation service. Signing is not allowed.'),`
`76`	`76`	`CrlValidationStatus::VALIDATION_ERROR => $this->identifyService->getL10n()->t('An error occurred during certificate validation. Signing is not allowed.'),`