Skip to content

Commit 489797f

Browse files
refactor(FileService): remove redundant docblock from private method
The method name extractValidSignRequestId() and its return type ?int already express the full contract. The comment was paraphrasing both without adding new information. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
1 parent a153fc5 commit 489797f

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

lib/Service/FileService.php

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -664,21 +664,17 @@ private function mapSignerDetailsToSummary(array $signers): array {
664664
return $summaries;
665665
}
666666

667-
/**
668-
* Extracts and type-casts signRequestId from signer data.
669-
* Returns null if signRequestId is missing, null, non-numeric, or cannot be converted.
670-
*/
671667
private function extractValidSignRequestId(array $signerData): ?int {
672668
$signRequestId = $signerData['signRequestId'] ?? null;
673-
669+
674670
if (is_int($signRequestId)) {
675671
return $signRequestId;
676672
}
677-
673+
678674
if (is_string($signRequestId) && ctype_digit($signRequestId)) {
679675
return (int)$signRequestId;
680676
}
681-
677+
682678
return null;
683679
}
684680

0 commit comments

Comments
 (0)