Skip to content

Commit 479a670

Browse files
test(e2e): fix selectors in parallel multi-signer test
- Remove tab clicks: with only one method (email) enabled the tab bar is not rendered; clicking by role='tab' would hang or fail - Add .click() before .fill() on the Email placeholder to trigger the Vue autocomplete event - Replace getByRole('switch') with getByLabel(): NcCheckboxRadioSwitch renders as <input type="checkbox">, not role="switch" (upstream bug) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
1 parent 501c554 commit 479a670

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

playwright/e2e/multi-signer-parallel.spec.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,25 +41,25 @@ test('request signatures from two signers in parallel', async ({ page }) => {
4141
await page.getByRole('textbox', { name: 'URL of a PDF file' }).fill('https://raw.githubusercontent.com/LibreSign/libresign/main/tests/php/fixtures/pdfs/small_valid.pdf')
4242
await page.getByRole('button', { name: 'Send' }).click()
4343

44-
// Add first signer via email tab
44+
// Add first signer — only email method is active, so the field appears directly (no tabs)
4545
await page.getByRole('button', { name: 'Add signer' }).click()
46-
await page.getByRole('tab', { name: 'Email' }).click()
46+
await page.getByPlaceholder('Email').click()
4747
await page.getByPlaceholder('Email').fill('signer01@libresign.coop')
4848
await page.getByRole('option', { name: 'signer01@libresign.coop' }).click()
4949
await page.getByRole('textbox', { name: 'Signer name' }).fill('Signer 01')
5050
await page.getByRole('button', { name: 'Save' }).click()
5151

52-
// Add second signer via email tab
52+
// Add second signer
5353
await page.getByRole('button', { name: 'Add signer' }).click()
54-
await page.getByRole('tab', { name: 'Email' }).click()
54+
await page.getByPlaceholder('Email').click()
5555
await page.getByPlaceholder('Email').fill('signer02@libresign.coop')
5656
await page.getByRole('option', { name: 'signer02@libresign.coop' }).click()
5757
await page.getByRole('textbox', { name: 'Signer name' }).fill('Signer 02')
5858
await page.getByRole('button', { name: 'Save' }).click()
5959

6060
// With 2+ signers the "Sign in order" switch must be visible and unchecked by default,
6161
// meaning parallel flow — both signers will be notified at the same time.
62-
const signInOrderSwitch = page.getByRole('switch', { name: 'Sign in order' })
62+
const signInOrderSwitch = page.getByLabel('Sign in order')
6363
await expect(signInOrderSwitch).toBeVisible()
6464
await expect(signInOrderSwitch).not.toBeChecked()
6565

0 commit comments

Comments
 (0)