Don't compute degrees_dist2 if not needed

Author: amontoison

src/order.jl

@@ -273,7 +273,7 @@ function rotate_bucket_right!(db::DegreeBuckets, d::Integer)
     return nothing
 end
 
-function update_bucket!(db::DegreeBuckets, v::Integer; degtype, direction)
+function update_bucket!(db::DegreeBuckets, v::Integer; degtype::Symbol, direction::Symbol)
     (; degrees, bucket_storage, bucket_low, bucket_high, positions, reproduce_colpack) = db
     d, p = degrees[v], positions[v]
     low, high = bucket_low[d + 1], bucket_high[d + 1]
@@ -362,34 +362,32 @@ function vertices(
     g::BipartiteGraph{T}, ::Val{side}, order::DynamicDegreeBasedOrder{degtype,direction}
 ) where {T<:Integer,side,degtype,direction}
     other_side = 3 - side
-    # compute dist-2 degrees in an optimized way
     n = nb_vertices(g, Val(side))
     degrees_dist2 = zeros(T, n)
     visited = fill(false, n)
     vertices_visited = zeros(T, n-1)
     num_visited = zero(T)
-    for v in vertices(g, Val(side))
-        for w1 in neighbors(g, Val(side), v)
-            for w2 in neighbors(g, Val(other_side), w1)
-                if w2 != v && !visited[w2]
-                    degrees_dist2[v] += 1
-                    visited[w2] = true
-                    num_visited += 1
-                    vertices_visited[num_visited] = w2
+    # compute dist-2 degrees in an optimized way (if needed)
+    if degree_increasing(; degtype, direction)
+        for v in vertices(g, Val(side))
+            for w1 in neighbors(g, Val(side), v)
+                for w2 in neighbors(g, Val(other_side), w1)
+                    if w2 != v && !visited[w2]
+                        degrees_dist2[v] += 1
+                        visited[w2] = true
+                        num_visited += 1
+                        vertices_visited[num_visited] = w2
+                    end
                 end
             end
+            for k in 1:num_visited
+                z = vertices_visited[k]
+                visited[z] = false
+            end
+            num_visited = 0
         end
-        for k in 1:num_visited
-            z = vertices_visited[k]
-            visited[z] = false
-        end
-        num_visited = 0
-    end
-    if degree_increasing(; degtype, direction)
-        degrees = zeros(T, n)
-    else
-        degrees = degrees_dist2
     end
+    degrees = degrees_dist2
     maxd2 = maximum(degrees_dist2)
     db = DegreeBuckets(T, degrees, maxd2; reproduce_colpack=order.reproduce_colpack)
     π = T[]