Fix StackOverflow

Author: gdalle

src/constant.jl

@@ -99,35 +99,36 @@ function ConstantColoringAlgorithm(
     return ConstantColoringAlgorithm{partition}(matrix_template, color)
 end
 
-function coloring(
-    A::AbstractMatrix,
-    ::ColoringProblem{:nonsymmetric,partition},
-    algo::ConstantColoringAlgorithm{partition};
-    decompression_eltype::Type=Float64,
-    symmetric_pattern::Bool=false,
-) where {partition}
-    (; matrix_template, result) = algo
+function check_template(algo::ConstantColoringAlgorithm, A::AbstractMatrix)
+    (; matrix_template) = algo
     if size(A) != size(matrix_template)
         throw(
             DimensionMismatch(
                 "`ConstantColoringAlgorithm` expected matrix of size $(size(matrix_template)) but got matrix of size $(size(A))",
             ),
         )
-    else
-        return result
     end
 end
 
+function coloring(
+    A::AbstractMatrix,
+    ::ColoringProblem{:nonsymmetric,partition},
+    algo::ConstantColoringAlgorithm{partition};
+    decompression_eltype::Type=Float64,
+    symmetric_pattern::Bool=false,
+) where {partition}
+    check_template(algo, A)
+    return algo.result
+end
+
 function ADTypes.column_coloring(
     A::AbstractMatrix, algo::ConstantColoringAlgorithm{:column}
 )
-    problem = ColoringProblem{:nonsymmetric,:column}()
-    result = coloring(A, problem, algo)
-    return column_colors(result)
+    check_template(algo, A)
+    return column_colors(algo.result)
 end
 
-function ADTypes.row_coloring(A::AbstractMatrix, algo::ConstantColoringAlgorithm)
-    problem = ColoringProblem{:nonsymmetric,:row}()
-    result = coloring(A, problem, algo)
-    return row_colors(result)
+function ADTypes.row_coloring(A::AbstractMatrix, algo::ConstantColoringAlgorithm{:row})
+    check_template(algo, A)
+    return row_colors(algo.result)
 end

test/constant.jl

@@ -27,11 +27,3 @@ end
     @test ADTypes.row_coloring(matrix_template, algo) == color
     @test_throws MethodError ADTypes.column_coloring(matrix_template, algo)
 end
-
-@testset "Symmetric coloring" begin
-    wrong_problem = ColoringProblem(; structure=:symmetric, partition=:column)
-    color = rand(1:5, size(matrix_template, 2))
-    algo = ConstantColoringAlgorithm(matrix_template, color; partition=:column)
-    @test_throws MethodError coloring(matrix_template, wrong_problem, algo)
-    @test_throws MethodError ADTypes.symmetric_coloring(matrix_template, algo)
-end