Skip to content

Commit 38ba304

Browse files
committed
Only substitution
1 parent 13300d2 commit 38ba304

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

src/order.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ Instance of [`AbstractOrder`](@ref) which computes a perfect elimination orderin
311311
The `elimination_algorithm` must be an instance of `CliqueTrees.EliminationAlgorithm`.
312312
313313
!!! warning
314-
This order can only be applied for symmetric or bidirectional coloring problems.
314+
This order can only be applied for symmetric or bidirectional coloring problems. Furthermore, its theoretical guarantees only hold for decompression by substitution.
315315
316316
!!! danger
317317
This order is implemented as a package extension and requires loading [CliqueTrees.jl](https://github.com/AlgebraicJulia/CliqueTrees.jl).

test/order.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,8 @@ end;
116116

117117
@testset "PerfectEliminationOrder" begin
118118
problem = ColoringProblem(; structure=:symmetric, partition=:column)
119-
direct_algo = GreedyColoringAlgorithm(PerfectEliminationOrder(); decompression=:direct)
120119
substitution_algo = GreedyColoringAlgorithm(
121-
PerfectEliminationOrder(CliqueTrees.LexBFS()); decompression=:substitution
120+
PerfectEliminationOrder(); decompression=:substitution
122121
)
123122

124123
# band graphs
@@ -127,7 +126,6 @@ end;
127126
matrix = permute!(sparse(Symmetric(brand(n, n, m, 0), :L)), perm, perm)
128127
π = vertices(AdjacencyGraph(matrix), PerfectEliminationOrder())
129128
@test isperm(π)
130-
@test ncolors(coloring(matrix, problem, direct_algo)) == 2m + 1
131129
@test ncolors(coloring(matrix, problem, substitution_algo)) == m + 1
132130
end
133131

0 commit comments

Comments
 (0)