Merge branch 'main' into gd/structured

Author: gdalle

src/graph.jl

@@ -24,17 +24,7 @@ end
 SparsityPatternCSC(A::SparseMatrixCSC) = SparsityPatternCSC(A.m, A.n, A.colptr, A.rowval)
 
 Base.size(S::SparsityPatternCSC) = (S.m, S.n)
-
-function Base.size(S::SparsityPatternCSC, d::Integer)
-    if d == 1
-        return S.m
-    elseif d == 2
-        return S.n
-    else
-        return 1
-    end
-end
-
+Base.size(S::SparsityPatternCSC, d) = d::Integer <= 2 ? size(S)[d] : 1
 Base.axes(S::SparsityPatternCSC, d::Integer) = Base.OneTo(size(S, d))
 
 SparseArrays.nnz(S::SparsityPatternCSC) = length(S.rowval)

test/graph.jl

@@ -27,6 +27,7 @@ using Test
         A = spzeros(10, 20)
         S = SparsityPatternCSC(A)
         @test size(A) == size(S)
+        @test_throws BoundsError size(A, 0)
         @test size(A, 1) == size(S, 1)
         @test size(A, 2) == size(S, 2)
         @test size(A, 3) == size(S, 3)

test/utils.jl

@@ -4,11 +4,7 @@ using BlockBandedMatrices: BlockBandedMatrix
 using LinearAlgebra
 using SparseMatrixColorings
 using SparseMatrixColorings:
-    AdjacencyGraph,
-    LinearSystemColoringResult,
-    matrix_versions,
-    respectful_similar,
-    structurally_orthogonal_columns
+    AdjacencyGraph, LinearSystemColoringResult, matrix_versions, respectful_similar
 using Test
 
 function test_coloring_decompression(