rm BackHesVec, and move autoback_hesvec to HesVec(autodiff=AutoZygote())

Author: vpuri3

src/SparseDiffTools.jl

@@ -49,7 +49,7 @@ export contract_color,
        autonum_hesvec, autonum_hesvec!,
        num_hesvecgrad, num_hesvecgrad!,
        auto_hesvecgrad, auto_hesvecgrad!,
-       JacVec, HesVec, BackHesVec, HesVecGrad, VecJac,
+       JacVec, HesVec, HesVecGrad, VecJac,
        update_coefficients, update_coefficients!,
        value!
 

src/differentiation/jaches_products.jl

@@ -271,32 +271,6 @@ function HesVec(f, u::AbstractArray, p = nothing, t = nothing; autodiff = AutoFo
         cache3 = similar(u)
 
         (cache1, cache2, cache3), numauto_hesvec, numauto_hesvec!
-    else
-        @error("Set autodiff to either AutoForwardDiff(), or AutoFiniteDiff()")
-    end
-
-    outofplace = static_hasmethod(f, typeof((u,)))
-    isinplace  = static_hasmethod(f, typeof((u,)))
-
-    if !(isinplace) & !(outofplace)
-        error("$f must have signature f(u).")
-    end
-
-    L = FwdModeAutoDiffVecProd(f, u, cache, vecprod, vecprod!)
-
-    FunctionOperator(L, u, u;
-                     isinplace = isinplace, outofplace = outofplace,
-                     p = p, t = t, islinear = true,
-                    )
-end
-
-function BackHesVec(f, u::AbstractArray, p = nothing, t = nothing; autodiff = AutoFiniteDiff())
-
-    cache, vecprod, vecprod! = if autodiff isa AutoFiniteDiff
-        cache1 = similar(u)
-        cache2 = similar(u)
-
-        (cache1, cache2), numback_hesvec, numback_hesvec!
     elseif autodiff isa AutoZygote
         @assert static_hasmethod(autoback_hesvec, typeof((f, u, u))) "To use AutoZygote() AD, first load Zygote with `using Zygote`, or `import Zygote`"
 
@@ -306,6 +280,8 @@ function BackHesVec(f, u::AbstractArray, p = nothing, t = nothing; autodiff = Au
         cache2 = copy(u)
 
         (cache1, cache2), autoback_hesvec, autoback_hesvec!
+    else
+        @error("Set autodiff to either AutoForwardDiff(), or AutoFiniteDiff()")
     end
 
     outofplace = static_hasmethod(f, typeof((u,)))

test/test_jaches_products.jl

@@ -113,21 +113,12 @@ dy=rand(N);_dy=copy(dy);@test mul!(dy,L,v,a,b)≈a*numauto_hesvec(g,x,v)+b*_dy r
 out = similar(v)
 gmres!(out, L, v)
 
-@info "BackHesVec"
 using Zygote
+
 x = rand(N)
 v = rand(N)
 
-L = BackHesVec(g, x)
-@test L * x ≈ numback_hesvec(g, x, x) rtol = 1e-2
-@test L * v ≈ numback_hesvec(g, x, v) rtol = 1e-2
-@test mul!(dy, L, v)≈numback_hesvec(g, x, v) rtol=1e-2
-dy=rand(N);_dy=copy(dy);@test mul!(dy,L,v,a,b) ≈ a*numback_hesvec(g,x,v) + b*_dy rtol=1e-2
-update_coefficients!(L, v, nothing, 0.0)
-@test mul!(dy, L, v)≈numback_hesvec(g, v, v) rtol=1e-2
-dy=rand(N);_dy=copy(dy);@test mul!(dy,L,v,a,b) ≈ a*numback_hesvec(g,x,v) + b*_dy rtol=1e-2
-
-L = BackHesVec(g, x, autodiff = AutoZygote())
+L = HesVec(g, x, autodiff = AutoZygote())
 @test L * x ≈ autoback_hesvec(g, x, x)
 @test L * v ≈ autoback_hesvec(g, x, v)
 @test mul!(dy, L, v)≈autoback_hesvec(g, x, v) rtol=1e-8
@@ -139,7 +130,6 @@ dy=rand(N);_dy=copy(dy);@test mul!(dy,L,v,a,b)≈a*autoback_hesvec(g,x,v)+b*_dy
 out = similar(v)
 gmres!(out, L, v)
 
-
 @info "HesVecGrad"
 
 x = rand(N)