iip,oop

Author: vpuri3

src/differentiation/jaches_products.jl

@@ -241,10 +241,17 @@ function JacVec(f, u::AbstractArray, p = nothing, t = nothing; autodiff = true)
     vecprod  = autodiff ? auto_jacvec  : num_jacvec
     vecprod! = autodiff ? auto_jacvec! : num_jacvec!
 
+    outofplace = static_hasmethod(f, typeof((u,)))
+    isinplace  = static_hasmethod(f, typeof((u, u,)))
+
+    if !(isinplace) & !(outofplace)
+        error("$f must have signature f(u), or f(du, u).")
+    end
+
     L = FwdModeAutoDiffVecProd(f, u, cache, vecprod, vecprod!)
 
     FunctionOperator(L, u, u;
-                     isinplace = true, outofplace = true,
+                     isinplace = isinplace, outofplace = outofplace,
                      p = p, t = t, islinear = true,
                     )
 end
@@ -266,10 +273,17 @@ function HesVec(f, u::AbstractArray, p = nothing, t = nothing; autodiff = true)
     vecprod  = autodiff ? numauto_hesvec  : num_hesvec
     vecprod! = autodiff ? numauto_hesvec! : num_hesvec!
 
+    outofplace = static_hasmethod(f, typeof((u,)))
+    isinplace  = static_hasmethod(f, typeof((u,)))
+
+    if !(isinplace) & !(outofplace)
+        error("$f must have signature f(u).")
+    end
+
     L = FwdModeAutoDiffVecProd(f, u, cache, vecprod, vecprod!)
 
     FunctionOperator(L, u, u;
-                     isinplace = true, outofplace = true,
+                     isinplace = isinplace, outofplace = outofplace,
                      p = p, t = t, islinear = true,
                     )
 end
@@ -292,10 +306,17 @@ function HesVecGrad(f, u::AbstractArray, p = nothing, t = nothing; autodiff = tr
     vecprod  = autodiff ? auto_hesvecgrad  : num_hesvecgrad
     vecprod! = autodiff ? auto_hesvecgrad! : num_hesvecgrad!
 
+    outofplace = static_hasmethod(f, typeof((u,)))
+    isinplace  = static_hasmethod(f, typeof((u, u,)))
+
+    if !(isinplace) & !(outofplace)
+        error("$f must have signature f(u), or f(du, u).")
+    end
+
     L = FwdModeAutoDiffVecProd(f, u, cache, vecprod, vecprod!)
 
     FunctionOperator(L, u, u;
-                     isinplace = true, outofplace = true,
+                     isinplace = isinplace, outofplace = outofplace,
                      p = p, t = t, islinear = true,
                     )
 end

src/differentiation/vecjac_products.jl

@@ -94,8 +94,8 @@ function VecJac(f, u::AbstractArray, p = nothing, t = nothing; autodiff = true,
     vecprod  = autodiff ? auto_vecjac  : num_vecjac
     vecprod! = autodiff ? auto_vecjac! : num_vecjac!
 
-    isinplace  = static_hasmethod(f, typeof((u, p, t)))
-    outofplace = static_hasmethod(f, typeof((u, u, p, t)))
+    outofplace = static_hasmethod(f, typeof((u, p, t)))
+    isinplace  = static_hasmethod(f, typeof((u, u, p, t)))
 
     if !(isinplace) & !(outofplace)
         error("$f must have signature f(u, p, t), or f(du, u, p, t)")

test/test_jaches_products.jl

@@ -65,7 +65,7 @@ cache4 = ForwardDiff.Dual{typeof(ForwardDiff.Tag(Nothing, eltype(x))), eltype(x)
 @test auto_hesvecgrad!(dy, h, x, v, cache1, cache2)≈ForwardDiff.hessian(g, x) * v rtol=1e-2
 @test auto_hesvecgrad(h, x, v)≈ForwardDiff.hessian(g, x) * v rtol=1e-2
 
-### JacVec
+@info "JacVec"
 
 L = JacVec(f, x)
 @test L * x ≈ auto_jacvec(f, x, x)
@@ -88,7 +88,7 @@ dy=rand(N);_dy=copy(dy);@test mul!(dy,L,v,a,b) ≈ a*num_jacvec(f,x,v) + b*_dy r
 out = similar(v)
 gmres!(out, L, v)
 
-### HesVec
+@info "HesVec"
 
 x = rand(N)
 v = rand(N)
@@ -113,7 +113,7 @@ dy=rand(N);_dy=copy(dy);@test mul!(dy,L,v,a,b)≈a*numauto_hesvec(g,x,v)+b*_dy r
 out = similar(v)
 gmres!(out, L, v)
 
-### HesVecGrad
+@info "HesVecGrad"
 
 x = rand(N)
 v = rand(N)