Re-enable some tests (#1539)

* Re-enable test_print

* Re-enable test_set

* Re-enable test_array

* Add missing file

* Fix test failure

* Re-enable test_support

* Re-enable test_string_literals

* Fix test failure

* Mark as failing on macOS

Author: slozier

Src/IronPython.Modules/array.cs

@@ -196,11 +196,7 @@ public array InPlaceMultiply(int value) {
                 if (value <= 0) {
                     _data.Clear();
                 } else {
-                    var myData = __copy__();
-
-                    for (int i = 0; i < (value - 1); i++) {
-                        ExtendArray(myData);
-                    }
+                    _data.InPlaceMultiply(value);
                 }
                 return this;
             }

Src/IronPython.Modules/nt.cs

@@ -817,7 +817,7 @@ public static void mkdir([NotNone] string path, [ParamDictionary, NotNone] IDict
                 }
             }
 
-            if (Directory.Exists(path)) throw DirectoryExists();
+            if (Directory.Exists(path)) throw DirectoryExistsError(path);
             // we ignore mode
 
             try {
@@ -2209,8 +2209,13 @@ private static bool TryGetShellCommand(string command, [NotNullWhen(true)] out s
 
 #endif
 
-        private static Exception DirectoryExists() {
-            return PythonOps.OSError(PythonExceptions._OSError.ERROR_ALREADY_EXISTS, "directory already exists", null, PythonExceptions._OSError.ERROR_ALREADY_EXISTS);
+        private static Exception DirectoryExistsError(string? filename) {
+#if FEATURE_NATIVE
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) {
+                return GetWin32Error(PythonExceptions._OSError.ERROR_ALREADY_EXISTS, filename);
+            }
+#endif
+            return GetOsError(PythonErrorNumber.EEXIST, filename);
         }
 
 #if FEATURE_NATIVE

Src/IronPython/Runtime/ArrayData.cs

@@ -27,6 +27,7 @@ internal interface ArrayData : IList {
         void InsertRange(int index, int count, ArrayData value);
         void RemoveSlice(Slice slice);
         ArrayData Multiply(int count);
+        void InPlaceMultiply(int count);
         new bool Remove(object? item);
         void Reverse();
         Span<byte> AsByteSpan();

Src/IronPythonTest/Cases/CPythonCasesManifest.ini

@@ -114,8 +114,8 @@ Reason=ImportError: No module named audioop
 Ignore=true
 Reason=unittest.case.SkipTest: test irrelevant for an installed Python
 
-[CPython.test_array]
-IsolationLevel=PROCESS # https://github.com/IronLanguages/ironpython3/issues/489
+[CPython.test_array] # IronPython.test_array_stdlib
+Ignore=true
 
 [CPython.test_ast]
 Ignore=true
@@ -756,6 +756,9 @@ Reason=unittest.case.SkipTest: No module named 'posix'
 [CPython.test_posixpath]
 Ignore=true
 
+[CPython.test_print] # IronPython.test_print_stdlib
+Ignore=true
+
 [CPython.test_profile]
 Ignore=true
 
@@ -832,9 +835,8 @@ Ignore=true
 [CPython.test_selectors]
 Ignore=true
 
-[CPython.test_set]
-RunCondition=NOT $(IS_MONO) # weakref failures; https://github.com/IronLanguages/ironpython3/issues/544
-IsolationLevel=PROCESS # Also weakref failures; https://github.com/IronLanguages/ironpython3/issues/489
+[CPython.test_set] # IronPython.test_set_stdlib
+Ignore=true
 
 [CPython.test_shelve]
 NotParallelSafe=true
@@ -885,6 +887,9 @@ Ignore=true
 [CPython.test_strftime]
 Ignore=true
 
+[CPython.test_string_literals] # IronPython.test_string_literals_stdlib
+Ignore=true
+
 [CPython.test_stringprep]
 Ignore=true
 Reason=Requires unicode 3.2.0 data - https://github.com/IronLanguages/ironpython3/issues/691
@@ -924,8 +929,8 @@ Reason=ImportError: No module named _msi
 [CPython.test_super]
 Ignore=true
 
-[CPython.test_support]
-RunCondition=NOT $(IS_POSIX) # TODO: debug
+[CPython.test_support] # IronPython.test_support_stdlib
+Ignore=true
 
 [CPython.test_symtable]
 Ignore=true
@@ -1179,9 +1184,6 @@ Ignore=true # 2 failures
 [CPython.test_abc]
 Ignore=true # test_works_with_init_subclass - https://github.com/IronLanguages/ironpython3/issues/1448
 
-[CPython.test_array]
-Ignore=true # test_free_after_iterating/test_type_error
-
 [CPython.test_asyncio.test_selector_events]
 Ignore=true # blocking
 
@@ -1215,23 +1217,11 @@ Ignore=true # __annotations__
 [CPython.test_ordered_dict]
 Ignore=true # multiple failures
 
-[CPython.test_print]
-Ignore=true # 7 failures
-
 [CPython.test_regrtest]
 Ignore=true # lots of failures
 
-[CPython.test_set]
-Ignore=true # test_hash_effectiveness
-
 [CPython.test_spwd]
 Ignore=true # fails on macOS
 
-[CPython.test_string_literals]
-Ignore=true # AssertionError: DeprecationWarning not triggered
-
-[CPython.test_support]
-Ignore=true # lots of failures
-
 [CPython.test_userlist]
 Ignore=true # test_free_after_iterating

Src/IronPythonTest/Cases/IronPythonCasesManifest.ini

@@ -4,6 +4,9 @@ WorkingDirectory=$(TEST_FILE_DIR)
 Redirect=false
 Timeout=120000 # 2 minute timeout
 
+[CPython.test_array_stdlib]
+IsolationLevel=PROCESS # https://github.com/IronLanguages/ironpython3/issues/489
+
 [IronPython.test_builtin_stdlib]
 RunCondition=NOT $(IS_MONO)
 Reason=Exception on adding DocTestSuite
@@ -90,6 +93,10 @@ RetryCount=2
 IsolationLevel=PROCESS
 Arguments=-X:CompilationThreshold 0 "$(TEST_FILE)" # ensure CompilationThreshold is 0 otherwise tests are meaningless!
 
+[IronPython.test_set_stdlib]
+RunCondition=NOT $(IS_MONO) # weakref failures; https://github.com/IronLanguages/ironpython3/issues/544
+IsolationLevel=PROCESS # Also weakref failures; https://github.com/IronLanguages/ironpython3/issues/489
+
 [IronPython.test_socket_stdlib]
 RunCondition=NOT $(IS_MONO) # TODO: figure out
 

Src/StdLib/Lib/test/test_array.py

@@ -1039,7 +1039,6 @@ def test_bug_782369(self):
             b = array.array('B', range(64))
         self.assertEqual(rc, sys.getrefcount(10))
 
-    @unittest.skipIf(sys.implementation.name == "ironpython", "TODO: https://github.com/IronLanguages/ironpython3/issues/767")
     def test_subclass_with_kwargs(self):
         # SF bug #1486663 -- this used to erroneously raise a TypeError
         ArraySubclassWithKwargs('b', newarg=1)
@@ -1368,7 +1367,6 @@ class DoubleTest(FPTest, unittest.TestCase):
     typecode = 'd'
     minitemsize = 8
 
-    @unittest.skipIf(sys.implementation.name == "ironpython", "TODO: https://github.com/IronLanguages/ironpython3/issues/767")
     def test_alloc_overflow(self):
         from sys import maxsize
         a = array.array('d', [-1]*65536)

Src/StdLib/Lib/test/test_set.py

@@ -333,7 +333,6 @@ def test_cyclical_print(self):
             fo.close()
             support.unlink(support.TESTFN)
 
-    @unittest.skipIf(sys.implementation.name == "ironpython", "https://github.com/IronLanguages/ironpython3/issues/848")
     def test_do_not_rehash_dict_keys(self):
         n = 10
         d = dict.fromkeys(map(HashCountingInt, range(n)))

Src/StdLib/Lib/test/test_support.py

@@ -270,7 +270,7 @@ def test_make_bad_fd(self):
         self.assertEqual(cm.exception.errno, errno.EBADF)
 
     def test_check_syntax_error(self):
-        support.check_syntax_error(self, "def class", lineno=1, offset=9)
+        support.check_syntax_error(self, "def class", lineno=1, offset=5)
         with self.assertRaises(AssertionError):
             support.check_syntax_error(self, "x=1")