Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Commit 941b4c5

Browse files
committed
fixing typing for InlineClosureCallPass
We recently detected integration testing failures with the latest Numba master and the latest released version of HPAT. Specifically, the following error was raised: ``` ====================================================================== FAIL: test_kmeans (hpat.tests.test_ml.TestML) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/circleci/repo/miniconda3/envs/hpat/lib/python3.6/site-packages/hpat/tests/test_ml.py", line 110, in test_kmeans self.assertEqual(count_array_OneDs(), 4) AssertionError: 0 != 4 ``` A CI build log can be found here: https://circleci.com/gh/numba/numba-integration-testing/24 Using `git bisect` the following offending commit was detected in the Numba Git history: `e5d8a41e15d4bbb7f2b81859dab210c9abdf8ccc is the first bad commit` And this was then traced to the following pull-request: numba/numba#3884 The problem here is, that `InlineClosureCallPass` was equipped with a new keyword argument `typed` which defaults to `False` bzut should be `True` in this case. This patch fixes that and makes the test-suite pass once again.
1 parent 127645a commit 941b4c5

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

hpat/compiler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ def stage_io_pass(self):
221221
def stage_repeat_inline_closure(self):
222222
assert self.func_ir
223223
inline_pass = InlineClosureCallPass(
224-
self.func_ir, self.flags.auto_parallel)
224+
self.func_ir, self.flags.auto_parallel, typed=True)
225225
inline_pass.run()
226226
post_proc = postproc.PostProcessor(self.func_ir)
227227
post_proc.run()

0 commit comments

Comments
 (0)