This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Commit 941b4c5
committed
fixing typing for InlineClosureCallPass
We recently detected integration testing failures with the latest Numba
master and the latest released version of HPAT.
Specifically, the following error was raised:
```
======================================================================
FAIL: test_kmeans (hpat.tests.test_ml.TestML)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/circleci/repo/miniconda3/envs/hpat/lib/python3.6/site-packages/hpat/tests/test_ml.py", line 110, in test_kmeans
self.assertEqual(count_array_OneDs(), 4)
AssertionError: 0 != 4
```
A CI build log can be found here:
https://circleci.com/gh/numba/numba-integration-testing/24
Using `git bisect` the following offending commit was detected in the
Numba Git history:
`e5d8a41e15d4bbb7f2b81859dab210c9abdf8ccc is the first bad commit`
And this was then traced to the following pull-request:
numba/numba#3884
The problem here is, that `InlineClosureCallPass` was equipped with a new
keyword argument `typed` which defaults to `False` bzut should be `True`
in this case.
This patch fixes that and makes the test-suite pass once again.1 parent 127645a commit 941b4c5
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
221 | 221 | | |
222 | 222 | | |
223 | 223 | | |
224 | | - | |
| 224 | + | |
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
| |||
0 commit comments