[Bug] App gets stuck in fullscreen/landscape mode

[slavalamp]

Checklist (Your issue will be automatically closed if you delete this part)

• I make sure that there are no existing issues - open or closed - which I could contribute my information to. This issue supersedes [Bug] get stuck in landscape #1153 :)
• I understand that issues with limited impact, such as those occurring on specific devices or under specific network conditions, will not be fixed.
• I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
• I have attached the error report in the issue. No error report available.

Describe the bug
The app can't return to the portrait rotation after entering fullscreen mode once

Frequency
Always

Steps to reproduce the bug

1. Have the device in portrait mode with autorotation disabled
2. Start playing a video and enter fullscreen mode (can be automatic with the "Start main player in fullscreen" option)
3. Exit fullscreen - the app remains in landscape mode
4. Press the back button - it only works as a back button, the app remains in landscape mode

Device (e.g. Pixel 9 Pro)
Google Pixel 6a

Error report
N/a

Additional context
This started in the 4.5.0 release.

[Davi427]

I'm also experiencing this on Galaxy Note 10+, Android 15, Pipepipe 4.5.0

[skorphil]

Same here on chinese tablet and android 14. Not sure when it started, but prob from 4.5.0

[InfinityLoop1308]

still works fine here. How do you Exit fullscreen? by the button or by swiping down?

[slavalamp]

By "Exit fullscreen" I meant the UI button, yeah. As far as I remember it used to work with both the fullscreen button and the back button, or maybe one of them? I have the muscle memory of doing both after finishing a video but neither exit fullscreen anymore.

I don't have swiping down enabled, I think it was the gesture that I kept doing on accident instead of brightness/volume and it was really annoying, so I forgot it existed at all. Just tested and it doesn't seem to work either though.... I think it might be exiting fullscreen but the app remains in landscape mode? not sure what the different states are called

More info: just saw the settings still open in portrait mode even when the rest of the app is locked in landscape

[InfinityLoop1308]

That's really strange.
Please try this build and let me know the toast info when exiting fullscreen
https://send.cyberjake.xyz/download/9a850ede0bbf523b/#-_ISm5-gkNsYXbq5xgdT9w

[slavalamp]

try this build

Entering fullscreen causes a crash in this one

Exception

• User Action: ui error
• Request: ACRA report
• Content Country: GB
• Content Language: en
• App Language: en
• Service: none
• Version: 4.5.0
• OS: Linux Android 15 - 35

Crash log

java.lang.NullPointerException: Can't toast on a thread that has not called Looper.prepare()
	at com.android.internal.util.Preconditions.checkNotNull(Preconditions.java:174)
	at android.widget.Toast.getLooper(Toast.java:188)
	at android.widget.Toast.<init>(Toast.java:173)
	at android.widget.Toast.makeText(Toast.java:518)
	at android.widget.Toast.makeText(Toast.java:507)
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment.onScreenRotationButtonClicked(VideoDetailFragment.java:2234)
	at org.schabi.newpipe.player.helper.PlayerHolder$1.onScreenRotationButtonClicked(PlayerHolder.java:229)
	at org.schabi.newpipe.player.Player.onScreenRotationButtonClicked(Player.java:2858)
	at org.schabi.newpipe.player.Player.lambda$onClick$48(Player.java:4251)
	at org.schabi.newpipe.player.Player.$r8$lambda$0LltpHX3axUA7vbbh_QxYQTit9s(Unknown Source:0)
	at org.schabi.newpipe.player.Player$$ExternalSyntheticLambda5.run(Unknown Source:2)
	at java.lang.Thread.run(Thread.java:1119)

---

[InfinityLoop1308]

Um I messed up the code. Use this build instead and let me know the notification when exiting full screen. (Make sure notification is enabled)

[slavalamp]

..."landscape: yes, tablet: yes, auto-locked: yes"

Looks like it's caused by tablet mode, disabling it makes stuff work fine.

I had enabled tablet mode some time ago to see if it makes any interface parts look nicer because 6 inches is a giant screen, but it seemingly changed nothing, so I forgot I had it enabled at all. ...is this what tablet mode means? (but the other people here are using tablets so I'm guessing it wasn't like this on tablets before)

Also I found another weird behavior:

• Launch the app, have tablet mode enabled
• Enable auto-rotate, keep the device vertical
• Start playing a landscape video and go into fullscreen (the button is still there for some reason... not sure how exactly to reproduce that actually, sometimes it disappears)
• It plays in portrait mode in fullscreen! and the notification says "landscape: no, auto-locked: no" accordingly

[InfinityLoop1308]

Yeah so the issue is caused by tablet mode. You really shouldn't enable it if your device is not as it's designed for tablets. The "weird" behavior is also expected for them.

@skorphil The pref is default to "auto", which translate to on for tablets, so if you don't want the behavior simply change it to off.

[slavalamp]

Maybe consider adding some kind of explanation of what the tablet mode is to the settings, or renaming it? It got at least two actual tablet users confused. Clearly it's not expected.

[Davi427]

Yeah so the issue is caused by tablet mode. You really shouldn't enable it if your device is not as it's designed for tablets. The "weird" behavior is also expected for them.

@skorphil The pref is default to "auto", which translate to on for tablets, so if you don't want the behavior simply change it to off.

On my device it is set to auto and the behaviour is not expected. Not by me anyway. I do not expect an app to hijack orientation locking unless I specifically tell it to, right?