Skip to content

Commit afd016c

Browse files
author
William Hou
committed
tweak task state success check
1 parent f257650 commit afd016c

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityScheduler.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1015,8 +1015,9 @@ private Optional<PendingType> handleCompletedTaskWithStatistics(
10151015

10161016
if (!isDeployInUse(requestDeployState, taskId.getDeployId(), true)) {
10171017
// failed tasks with remaining retries cannot short circuit here
1018+
// isFailed is false for lost and other weird task states
10181019
if (
1019-
!state.equals(ExtendedTaskState.TASK_FINISHED) &&
1020+
!state.isSuccess() &&
10201021
(
10211022
deployStatistics.getNumSequentialRetries() <
10221023
request.getNumRetriesOnFailure().orElse(0)

0 commit comments

Comments
 (0)