Remove extra verification step

Author: ssalinas

SingularityService/src/main/java/com/hubspot/singularity/config/SingularityConfiguration.java

@@ -458,7 +458,6 @@ public class SingularityConfiguration extends Configuration {
   private boolean skipPersistingTooLongTaskIds = false;
 
   private boolean allowEmptyRequestInstances = false;
-  private boolean verifyTaskDataWrites = false;
 
   public long getAskDriverToKillTasksAgainAfterMillis() {
     return askDriverToKillTasksAgainAfterMillis;
@@ -2152,12 +2151,4 @@ public boolean allowEmptyRequestInstances() {
   public void setAllowEmptyRequestInstances(boolean allowEmptyRequestInstances) {
     this.allowEmptyRequestInstances = allowEmptyRequestInstances;
   }
-
-  public boolean isVerifyTaskDataWrites() {
-    return verifyTaskDataWrites;
-  }
-
-  public void setVerifyTaskDataWrites(boolean verifyTaskDataWrites) {
-    this.verifyTaskDataWrites = verifyTaskDataWrites;
-  }
 }

SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java

@@ -1420,13 +1420,6 @@ private void createTaskAndDeletePendingTaskPrivate(SingularityTask task)
       // Not checking isActive here, already called within offer check flow
       leaderCache.putActiveTask(task.getTaskId());
       taskCache.set(path, task);
-      if (configuration.isVerifyTaskDataWrites()) {
-        Optional<SingularityTask> maybeTask = getTaskCheckCache(task.getTaskId(), true);
-        if (!maybeTask.isPresent()) {
-          LOG.error("Found empty task after write for {}", task.getTaskId());
-          saveTaskDeletePendingInTransaction(hasErr, path, task, taskStatusHolder);
-        }
-      }
     } catch (KeeperException.NodeExistsException nee) {
       LOG.error("Task or active path already existed for {}", task.getTaskId());
     } catch (Exception e) {