Add @masthead-data/dataform-plugin as a dependency and refactor reservation setter

Author: max-ostapenko

includes/reservations.js

@@ -1,4 +1,5 @@
-const default_reservation = null
+const reservations = require('@masthead-data/dataform-plugin')
+
 const RESERVATION_CONFIG = [
   {
     tag: 'high_slots',
@@ -24,61 +25,7 @@ const RESERVATION_CONFIG = [
   }
 ]
 
-const RESERVATION_SETS = RESERVATION_CONFIG.map(cfg => ({
-  ...cfg,
-  set: new Set(cfg.actions)
-}))
-
-
-/**
- * Extracts action name from Dataform context object
- * @param {Object} ctx - Dataform context object
- * @returns {string|null} The extracted action name or null if not found
- */
-function getActionName(ctx) {
-  if (!ctx) return null
-
-  if (typeof ctx.self === 'function' && !ctx?.operation) {
-    // Try primary method: ctx.self()
-    const selfName = ctx.self()
-    if (selfName) return selfName.replace(/`/g, '').trim()
-  } else if (ctx?.operation?.proto?.target) {
-    // Fallback: construct from proto target
-    const t = ctx?.operation?.proto?.target
-    return t ? [t.database, t.name].join('.') : null
-  }
-
-  return null
-}
-
-/**
- * Determines the appropriate reservation for a given action name
- * @param {string} actionName - The action name (without backticks)
- * @returns {string|null} The reservation identifier or null if no reservation assignment needed
- */
-function getReservation(actionName) {
-  if (!actionName || typeof actionName !== 'string') return default_reservation
-
-  for (const { reservation, set } of Object.values(RESERVATION_SETS)) {
-    if (set.has(actionName)) {
-      return reservation
-    }
-  }
-
-  return default_reservation
-}
-
-
-/**
- * Generates the reservation SQL statement for a given Dataform context
- * @param {Object} ctx - Dataform context object with self() method and/or proto.target
- * @returns {string} The SQL statement to set reservation or empty string
- */
-function reservation_setter(ctx) {
-  const actionName = getActionName(ctx)
-  const reservation = getReservation(actionName)
-  return reservation ? `SET @@reservation='${reservation}';` : ''
-}
+const reservation_setter = reservations.createReservationSetter(RESERVATION_CONFIG)
 
 module.exports = {
   reservation_setter

package-lock.json

@@ -7,7 +7,8 @@
     "superlint": "docker run --platform linux/amd64 -e DEFAULT_BRANCH=main -e VALIDATE_GIT_COMMITLINT=false -e VALIDATE_TERRAFORM_TERRASCAN=false -e VALIDATE_TERRAFORM_TFLINT=false -e FIX_JSON_PRETTIER=true -e IGNORE_GITIGNORED_FILES=true -e VALIDATE_ALL_CODEBASE=true -e VALIDATE_JSCPD=false -e RUN_LOCAL=true -v ./:/tmp/lint ghcr.io/super-linter/super-linter:slim-latest"
   },
   "dependencies": {
-    "@dataform/core": "3.0.30"
+    "@dataform/core": "3.0.30",
+    "@masthead-data/dataform-plugin": "0.0.1"
   },
   "devDependencies": {
     "eslint": "^9.35.0",