Skip to content

Commit 6ed820e

Browse files
committed
Update Docker image name to include source hash for service updates
1 parent 1c0bc81 commit 6ed820e

2 files changed

Lines changed: 4 additions & 8 deletions

File tree

infra/tf/bigquery_export/docker.tf

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,13 @@ data "external" "source_hash" {
2121

2222
# Build Docker image
2323
resource "docker_image" "function_image" {
24-
name = "${var.region}-docker.pkg.dev/${var.project}/dataform/${var.function_name}"
24+
# hash added to image tag to force rebuilds ans service image updates when source changes
25+
name = "${var.region}-docker.pkg.dev/${var.project}/dataform/${var.function_name}:${data.external.source_hash.result.hash}"
2526

2627
build {
2728
context = "../${var.function_name}/"
2829
platform = "linux/amd64"
2930
}
30-
triggers = {
31-
source_hash = data.external.source_hash.result.hash
32-
}
3331
}
3432

3533
resource "docker_registry_image" "registry_image" {

infra/tf/dataform_service/docker.tf

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,13 @@ data "external" "source_hash" {
2121

2222
# Build Docker image
2323
resource "docker_image" "function_image" {
24-
name = "${var.region}-docker.pkg.dev/${var.project}/dataform/${var.function_name}"
24+
# hash added to image tag to force rebuilds ans service image updates when source changes
25+
name = "${var.region}-docker.pkg.dev/${var.project}/dataform/${var.function_name}:${data.external.source_hash.result.hash}"
2526

2627
build {
2728
context = "../${var.function_name}/"
2829
platform = "linux/amd64"
2930
}
30-
triggers = {
31-
source_hash = data.external.source_hash.result.hash
32-
}
3331
}
3432

3533
resource "docker_registry_image" "registry_image" {

0 commit comments

Comments
 (0)