A collection of bugs

[HKaras]

Many thanks to Ashley (@redman-a) for identifying these bugs. I have opened a new branch v1.0.2 for their development,

Here is Ashley's comments:

• Perhaps EXT​ for external triggering should be added to the "det_modes​"

• For transient detection, TRANS, people use dig​ instead of acq​. Perhaps this should be given the same status and added to the "functions"​ ​list​

• I have only ever seen bsweep​ and the ENDOR defs variables rf and df​ ​formatted in all lowercase​

• I often see people format pulse length assignments and increments in the experiment blocks without spaces e.g. p2=p2+d30​ this means that the pulses do not meet the expected regex and are formatted incorrectly

• Perhaps variable names, such as a​, for transient averages, that are 'reserved' should be given special status and formatted differently?

[HKaras]

Perhaps EXT​ for external triggering should be added to the "det_modes​"
This is a good spot and easy fix.

For transient detection, TRANS, people use dig​ instead of acq​. Perhaps this should be given the same status and added to the "functions”​ ​list

Another good spot, and one that I thought I integrated. Maybe not. Out of pure curiosity, do you use transient mode much? We find it to be such a pain here that we try to avoid it at all costs.

I have only ever seen bsweep​ and the ENDOR defs variables rf and df​ ​formatted in all lowercase​

Another good spot, these were features that I added from the E580 manual but don’t use myself. Bruker’s own documentation seem to be inconsistent on this matter, and PulseSpel itself if case insensitive.

I often see people format pulse length assignments and increments in the experiment blocks without spaces e.g. p2=p2+d30​ this means that the pulses do not meet the expected regex and are formatted incorrectly

Well this was just pure laziness on my part. I was struggling to make it work so gave up, but you are right more effort should be put in to fix this.

Perhaps variable names, such as a​, for transient averages, that are 'reserved' should be given special status and formatted differently?

On this I am split in two mind. On one side this could be useful as most people (by most I really mean me) can never remember what is revered and what isn’t. However, this is a syntax highlighting add-on not a language server. There is also not much precedent on this as most well written languages don’t have reserved variables just keywords. Personally, I would lean towards highlighting them as normal variables. I also have a suspicion that what is reserved and what is not does depend on your Xepr Version and if you have an AWG or not. For example, I have used “a” before without any problem. Maybe it’s only reserved when using transient mode, something I have not had good experiences with.