Skip to content

Commit c7d7935

Browse files
ludochgae-java-bot
authored andcommitted
Update proto parsing method calls: In ModulesServiceImpl, simplify proto parsing by using parseFrom directly instead of creating a builder and merging, for SetNumInstancesResponse, StartModuleResponse, and StopModuleResponse. The parsed result is still unused.
PiperOrigin-RevId: 873167910 Change-Id: Idb6304efbb219d200d2c3e5229ddead6e92a016f
1 parent aab005b commit c7d7935

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

api/src/main/java/com/google/appengine/api/modules/ModulesServiceImpl.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -249,8 +249,7 @@ public Future<Void> setNumInstancesAsync(String module, String version, long ins
249249

250250
@Override
251251
protected Void wrap(byte[] key) throws InvalidProtocolBufferException {
252-
SetNumInstancesResponse.Builder responseBuilder = SetNumInstancesResponse.newBuilder();
253-
responseBuilder.mergeFrom(key);
252+
SetNumInstancesResponse unused = SetNumInstancesResponse.parseFrom(key);
254253
return null;
255254
}
256255
};
@@ -272,8 +271,7 @@ public Future<Void> startVersionAsync(String module, String version) {
272271

273272
@Override
274273
protected Void wrap(byte[] key) throws InvalidProtocolBufferException {
275-
StartModuleResponse.Builder responseBuilder = StartModuleResponse.newBuilder();
276-
responseBuilder.mergeFrom(key);
274+
StartModuleResponse unused = StartModuleResponse.parseFrom(key);
277275
return null;
278276
}
279277
};
@@ -300,8 +298,7 @@ public Future<Void> stopVersionAsync(String module, String version) {
300298

301299
@Override
302300
protected Void wrap(byte[] key) throws InvalidProtocolBufferException {
303-
StopModuleResponse.Builder responseBuilder = StopModuleResponse.newBuilder();
304-
responseBuilder.mergeFrom(key);
301+
StopModuleResponse unused = StopModuleResponse.parseFrom(key);
305302
return null;
306303
}
307304
};

0 commit comments

Comments
 (0)