Fixed all the known crashes introduced by the controller refactor.

Author: AndreaCatania

net_utilities.cpp

@@ -323,14 +323,18 @@ void NS::SyncGroup::notify_controller_changed(NS::ObjectData *p_object_data, int
 void NS::SyncGroup::notify_simulating_peers_about_listener_status(int p_peer_listener, bool p_simulating) {
 	for (int peer : simulating_peers) {
 		NetworkedControllerBase *controller = scene_sync->get_controller_for_peer(peer);
-		controller->server_set_peer_simulating_this_controller(p_peer_listener, p_simulating);
+		if (controller) {
+			controller->server_set_peer_simulating_this_controller(p_peer_listener, p_simulating);
+		}
 	}
 }
 
 void NS::SyncGroup::update_listeners_to_simulating_peer(int p_simulating_peer, bool p_simulating) {
 	NetworkedControllerBase *controller = scene_sync->get_controller_for_peer(p_simulating_peer);
-	for (int peer : listening_peers) {
-		controller->server_set_peer_simulating_this_controller(peer, p_simulating);
+	if (controller) {
+		for (int peer : listening_peers) {
+			controller->server_set_peer_simulating_this_controller(peer, p_simulating);
+		}
 	}
 }
 

networked_controller.cpp

@@ -9,6 +9,7 @@
 #include "modules/network_synchronizer/core/object_data.h"
 #include "modules/network_synchronizer/net_utilities.h"
 #include "modules/network_synchronizer/networked_controller.h"
+#include "modules/network_synchronizer/scene_synchronizer.h"
 #include "modules/network_synchronizer/scene_synchronizer_debugger.h"
 #include "net_utilities.h"
 #include "scene_synchronizer.h"
@@ -35,6 +36,8 @@ NetworkedControllerBase::~NetworkedControllerBase() {
 		controller = nullptr;
 		controller_type = CONTROLLER_TYPE_NULL;
 	}
+
+	remove_synchronizer();
 }
 
 void NetworkedControllerBase::notify_controllable_objects_changed() {
@@ -1367,7 +1370,7 @@ bool DollController::receive_inputs(const Vector<uint8_t> &p_data) {
 				SCParseTmpData *pd = static_cast<SCParseTmpData *>(p_user_pointer);
 
 				ASSERT_COND(p_frame_index != FrameIndex::NONE);
-				if (pd->controller->last_checked_input >= p_frame_index) {
+				if (pd->controller->last_checked_input != FrameIndex::NONE && pd->controller->last_checked_input >= p_frame_index) {
 					// This input is already processed.
 					return;
 				}

networked_controller.h

@@ -373,7 +373,7 @@ struct PlayerController final : public Controller {
 struct DollController final : public RemotelyControlledController {
 	DollController(NetworkedControllerBase *p_node);
 
-	FrameIndex last_checked_input = { 0 };
+	FrameIndex last_checked_input = FrameIndex::NONE;
 	int queued_instant_to_process = -1;
 
 	virtual bool receive_inputs(const Vector<uint8_t> &p_data) override;