Fixed desync bug. The characters were unable to reconcile in some cases.

Author: AndreaCatania

core/peer_networked_controller.cpp

@@ -1673,7 +1673,7 @@ void DollController::copy_controlled_objects_snapshot(
 		}
 
 		const std::vector<NameAndVar> *vars = p_snapshot.get_object_vars(object_data->get_net_id());
-		ENSURE_CONTINUE_MSG(vars, "The snapshot didn't contain the object: " + object_data->get_net_id() + ". If this error spams for a long period (5/10 seconds), it's a bug.");
+		ENSURE_CONTINUE_MSG(vars, "[FATAL] The snapshot didn't contain the object: " + object_data->get_net_id() + ". If this error spams for a long period (1/2 seconds) or never recover, it's a bug since.");
 
 		snap->data.simulated_objects.push_back(object_data->get_net_id());
 
@@ -1691,11 +1691,12 @@ void DollController::copy_controlled_objects_snapshot(
 }
 
 FrameIndex DollController::fetch_checkable_snapshot(DollSnapshot *&r_client_snapshot, DollSnapshot *&r_server_snapshot) {
+	clear_previously_generated_client_snapshots();
+
 	for (auto client_snap_it = client_snapshots.rbegin(); client_snap_it != client_snapshots.rend(); client_snap_it++) {
 		if (client_snap_it->doll_executed_input != FrameIndex::NONE) {
-#ifdef DEBUG_ENABLED
 			ASSERT_COND_MSG(client_snap_it->doll_executed_input <= current_input_buffer_id, "All the client snapshots are properly cleared when the `current_input_id` is manipulated. So this function is impossible to trigger. If it does, there is a bug on the `clear_previously_generated_client_snapshots`.");
-#endif
+
 			auto server_snap_it = VecFunc::find(server_snapshots, client_snap_it->doll_executed_input);
 			if (server_snap_it != server_snapshots.end()) {
 				r_client_snapshot = &(*client_snap_it);

scene_synchronizer.cpp

@@ -1,4 +1,3 @@
-
 #include "scene_synchronizer.h"
 
 #include "core/config/project_settings.h"

tests/test_doll_simulation.cpp

@@ -635,17 +635,17 @@ void test_simulation_with_wrong_input() {
 	test.assert_positions(NS::FrameIndex{ 0 }, NS::FrameIndex{ 0 });
 
 	// 2. Now introduce a desync on the server.
-	for (int test_count = 0; test_count < 4; test_count++) {
+	for (int test_count = 0; test_count < 5; test_count++) {
 		for (int i = 0; i < 3; i++) {
-			const NS::FrameIndex c1_assert_after = server_controller_1->get_current_frame_index() + 15;
-			const NS::FrameIndex c2_assert_after = server_controller_2->get_current_frame_index() + 15;
+			const NS::FrameIndex c1_assert_after = server_controller_1->get_current_frame_index() + 20;
+			const NS::FrameIndex c2_assert_after = server_controller_2->get_current_frame_index() + 20;
 			const int c1_desync_vec_size = test.peer1_desync_detected.size();
 			const int c2_desync_vec_size = test.peer2_desync_detected.size();
 
 			test.controlled_1_serv->modify_input_on_next_frame = true;
 			test.controlled_2_serv->modify_input_on_next_frame = true;
 			// Process 50 frames and ensure it recovers.
-			test.do_test(50);
+			test.do_test(75);
 
 			// Ensure there was a desync.
 			ASSERT_COND(test.peer1_desync_detected.size() > c1_desync_vec_size);