[fix] fixe the bug that preserving UnityEngine.PerformanceReportingModule when generating link.xml would cause the Android app built with Unity 2019 to crash on startup.

pirunxi · pirunxi · commit a11ebecf93f2 · 2025-01-18T22:55:37.000+08:00
diff --git a/Editor/Link/Analyzer.cs b/Editor/Link/Analyzer.cs
@@ -43,6 +43,11 @@ private void CollectUnityEngineCoreTypes(HashSet<ITypeDefOrRef> preservedTypes)
             var assCollector = new AssemblyCache(_resolver);
             foreach (string unityEngineDll in Directory.GetFiles(unityEngineDllPath, "UnityEngine.*.dll", SearchOption.AllDirectories))
             {
+                // because of bug of unity 2019.4.x, preserving types in this dll will cause crash in android build
+                if (unityEngineDll.EndsWith("UnityEngine.PerformanceReportingModule.dll", StringComparison.InvariantCulture))
+                {
+                    continue;
+                }
                 ModuleDefMD mod = assCollector.LoadModuleFromFileWithoutCache(unityEngineDll);
                 foreach (TypeDef type in mod.GetTypes())
                 {

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,11 @@ private void CollectUnityEngineCoreTypes(HashSet<ITypeDefOrRef> preservedTypes)`
`43`	`43`	`var assCollector = new AssemblyCache(_resolver);`
`44`	`44`	`foreach (string unityEngineDll in Directory.GetFiles(unityEngineDllPath, "UnityEngine.*.dll", SearchOption.AllDirectories))`
`45`	`45`	`{`
	`46`	`+ // because of bug of unity 2019.4.x, preserving types in this dll will cause crash in android build`
	`47`	`+ if (unityEngineDll.EndsWith("UnityEngine.PerformanceReportingModule.dll", StringComparison.InvariantCulture))`
	`48`	`+ {`
	`49`	`+ continue;`
	`50`	`+ }`
`46`	`51`	`ModuleDefMD mod = assCollector.LoadModuleFromFileWithoutCache(unityEngineDll);`
`47`	`52`	`foreach (TypeDef type in mod.GetTypes())`
`48`	`53`	`{`