[refactor] refactor code of settings.

Author: pirunxi

Editor/Settings/EditorStatusWatcher.cs

@@ -18,21 +18,21 @@ public class HybridCLRSettingsProvider : SettingsProvider
         private SerializedProperty _hotUpdateAssemblies;
         private SerializedProperty _preserveHotUpdateAssemblies;
         private SerializedProperty _hotUpdateDllCompileOutputRootDir;
-        private SerializedProperty _externalHotUpdateAssembliyDirs;
+        private SerializedProperty _externalHotUpdateAssemblyDirs;
         private SerializedProperty _strippedAOTDllOutputRootDir;
         private SerializedProperty _patchAOTAssemblies;
         private SerializedProperty _outputLinkFile;
         private SerializedProperty _outputAOTGenericReferenceFile;
         private SerializedProperty _maxGenericReferenceIteration;
         private SerializedProperty _maxMethodBridgeGenericIteration;
 
-        private GUIStyle buttonStyle;
         public HybridCLRSettingsProvider() : base("Project/HybridCLR Settings", SettingsScope.Project) { }
+
         public override void OnActivate(string searchContext, VisualElement rootElement)
         {
-            EditorStatusWatcher.OnEditorFocused += OnEditorFocused;
             InitGUI();
         }
+
         private void InitGUI()
         {
             var setting = HybridCLRSettings.LoadOrCreate();
@@ -46,133 +46,61 @@ private void InitGUI()
             _hotUpdateAssemblies = _serializedObject.FindProperty("hotUpdateAssemblies");
             _preserveHotUpdateAssemblies = _serializedObject.FindProperty("preserveHotUpdateAssemblies");
             _hotUpdateDllCompileOutputRootDir = _serializedObject.FindProperty("hotUpdateDllCompileOutputRootDir");
-            _externalHotUpdateAssembliyDirs = _serializedObject.FindProperty("externalHotUpdateAssembliyDirs");
+            _externalHotUpdateAssemblyDirs = _serializedObject.FindProperty("externalHotUpdateAssembliyDirs");
             _strippedAOTDllOutputRootDir = _serializedObject.FindProperty("strippedAOTDllOutputRootDir");
             _patchAOTAssemblies = _serializedObject.FindProperty("patchAOTAssemblies");
             _outputLinkFile = _serializedObject.FindProperty("outputLinkFile");
             _outputAOTGenericReferenceFile = _serializedObject.FindProperty("outputAOTGenericReferenceFile");
             _maxGenericReferenceIteration = _serializedObject.FindProperty("maxGenericReferenceIteration");
             _maxMethodBridgeGenericIteration = _serializedObject.FindProperty("maxMethodBridgeGenericIteration");
         }
-        private void OnEditorFocused()
-        {
-            InitGUI();
-            Repaint();
-        }
-        public override void OnTitleBarGUI()
-        {
-            base.OnTitleBarGUI();
-            var rect = GUILayoutUtility.GetLastRect();
-            buttonStyle = buttonStyle ?? GUI.skin.GetStyle("IconButton");
 
-            #region  绘制官方网站跳转按钮
-            var w = rect.x + rect.width;
-            rect.x = w - 57;
-            rect.y += 6;
-            rect.width = rect.height = 18;
-            var content = EditorGUIUtility.IconContent("_Help");
-            content.tooltip = "点击访问 HybridCLR 官方文档";
-            if (GUI.Button(rect, content, buttonStyle))
-            {
-                Application.OpenURL("https://hybridclr.doc.code-philosophy.com/");
-            }
-            #endregion
-            #region 绘制 Preset
-            rect.x += 19;
-            content = EditorGUIUtility.IconContent("Preset.Context");
-            content.tooltip = "点击存储或加载 Preset .";
-            if (GUI.Button(rect, content, buttonStyle))
-            {
-                var target = HybridCLRSettings.Instance;
-                var receiver = ScriptableObject.CreateInstance<SettingsPresetReceiver>();
-                receiver.Init(target, this);
-                PresetSelector.ShowSelector(target, null, true, receiver);
-            }
-            #endregion
-            #region 绘制 Reset
-            rect.x += 19;
-            content = EditorGUIUtility.IconContent(
-#if UNITY_2021_3_OR_NEWER
-                "pane options"
-#else
-                "_Popup"
-#endif
-                );
-            content.tooltip = "Reset";
-            if (GUI.Button(rect, content, buttonStyle))
-            {
-                GenericMenu menu = new GenericMenu();
-                menu.AddItem(new GUIContent("Reset"), false, () =>
-                {
-                    Undo.RecordObject(HybridCLRSettings.Instance, "Capture Value for Reset");
-                    var dv = ScriptableObject.CreateInstance<HybridCLRSettings>();
-                    var json = EditorJsonUtility.ToJson(dv);
-                    UnityEngine.Object.DestroyImmediate(dv);
-                    EditorJsonUtility.FromJsonOverwrite(json, HybridCLRSettings.Instance);
-                    HybridCLRSettings.Save();
-                });
-                menu.ShowAsContext();
-            }
-            #endregion
-        }
         public override void OnGUI(string searchContext)
         {
-            using (CreateSettingsWindowGUIScope())
+            if (_serializedObject == null || !_serializedObject.targetObject)
             {
-                if (_serializedObject == null||!_serializedObject.targetObject)
-                {
-                    InitGUI();
-                }
-                _serializedObject.Update();
-                EditorGUI.BeginChangeCheck();
-                EditorGUILayout.PropertyField(_enable);
-                EditorGUILayout.PropertyField(_hybridclrRepoURL);
-                EditorGUILayout.PropertyField(_il2cppPlusRepoURL);
-                EditorGUILayout.PropertyField(_useGlobalIl2cpp);
-                EditorGUILayout.PropertyField(_hotUpdateAssemblyDefinitions);
-                EditorGUILayout.PropertyField(_hotUpdateAssemblies);
-                EditorGUILayout.PropertyField(_preserveHotUpdateAssemblies);
-                EditorGUILayout.PropertyField(_hotUpdateDllCompileOutputRootDir);
-                EditorGUILayout.PropertyField(_externalHotUpdateAssembliyDirs);
-                EditorGUILayout.PropertyField(_strippedAOTDllOutputRootDir);
-                EditorGUILayout.PropertyField(_patchAOTAssemblies);
-                EditorGUILayout.PropertyField(_outputLinkFile);
-                EditorGUILayout.PropertyField(_outputAOTGenericReferenceFile);
-                EditorGUILayout.PropertyField(_maxGenericReferenceIteration);
-                EditorGUILayout.PropertyField(_maxMethodBridgeGenericIteration);
-                if (EditorGUI.EndChangeCheck())
-                {
-                    _serializedObject.ApplyModifiedProperties();
-                    HybridCLRSettings.Save();
-                }
+                InitGUI();
+            }
+            _serializedObject.Update();
+            EditorGUI.BeginChangeCheck();
+            EditorGUILayout.PropertyField(_enable);
+            EditorGUILayout.PropertyField(_hybridclrRepoURL);
+            EditorGUILayout.PropertyField(_il2cppPlusRepoURL);
+            EditorGUILayout.PropertyField(_useGlobalIl2cpp);
+            EditorGUILayout.PropertyField(_hotUpdateAssemblyDefinitions);
+            EditorGUILayout.PropertyField(_hotUpdateAssemblies);
+            EditorGUILayout.PropertyField(_preserveHotUpdateAssemblies);
+            EditorGUILayout.PropertyField(_hotUpdateDllCompileOutputRootDir);
+            EditorGUILayout.PropertyField(_externalHotUpdateAssemblyDirs);
+            EditorGUILayout.PropertyField(_strippedAOTDllOutputRootDir);
+            EditorGUILayout.PropertyField(_patchAOTAssemblies);
+            EditorGUILayout.PropertyField(_outputLinkFile);
+            EditorGUILayout.PropertyField(_outputAOTGenericReferenceFile);
+            EditorGUILayout.PropertyField(_maxGenericReferenceIteration);
+            EditorGUILayout.PropertyField(_maxMethodBridgeGenericIteration);
+            if (EditorGUI.EndChangeCheck())
+            {
+                _serializedObject.ApplyModifiedProperties();
+                HybridCLRSettings.Save();
             }
         }
-        private IDisposable CreateSettingsWindowGUIScope()
-        {
-            var unityEditorAssembly = Assembly.GetAssembly(typeof(EditorWindow));
-            var type = unityEditorAssembly.GetType("UnityEditor.SettingsWindow+GUIScope");
-            return Activator.CreateInstance(type) as IDisposable;
-        }
+
         public override void OnDeactivate()
         {
             base.OnDeactivate();
-            EditorStatusWatcher.OnEditorFocused -= OnEditorFocused;
             HybridCLRSettings.Save();
         }
 
-        static HybridCLRSettingsProvider provider;
+        static HybridCLRSettingsProvider s_provider;
+
         [SettingsProvider]
         public static SettingsProvider CreateMyCustomSettingsProvider()
         {
-            if (HybridCLRSettings.Instance && provider == null)
+            if (s_provider == null)
             {
-                provider = new HybridCLRSettingsProvider();
-                using (var so = new SerializedObject(HybridCLRSettings.Instance))
-                {
-                    provider.keywords = GetSearchKeywordsFromSerializedObject(so);
-                }
+                s_provider = new HybridCLRSettingsProvider();
             }
-            return provider;
+            return s_provider;
         }
     }
 }

Editor/Settings/EditorStatusWatcher.cs.meta

@@ -1,10 +1,11 @@
+using System.IO;
 using UnityEditorInternal;
 using UnityEngine;
 
 namespace HybridCLR.Editor.Settings
 {
-    [FilePath("ProjectSettings/HybridCLRSettings.asset")]
-    public class HybridCLRSettings : ScriptableSingleton<HybridCLRSettings>
+
+    public class HybridCLRSettings : ScriptableObject
     {
         [Tooltip("enable HybridCLR")]
         public bool enable = true;
@@ -50,5 +51,48 @@ public class HybridCLRSettings : ScriptableSingleton<HybridCLRSettings>
 
         [Tooltip("max iteration count of searching method bridge generic methods in AOT assemblies")]
         public int maxMethodBridgeGenericIteration = 10;
+
+
+
+        private static HybridCLRSettings s_Instance;
+
+        public static HybridCLRSettings Instance
+        {
+            get
+            {
+                if (!s_Instance)
+                {
+                    LoadOrCreate();
+                }
+                return s_Instance;
+            }
+        }
+
+        private static string GetFilePath()
+        {
+            return "ProjectSettings/HybridCLRSettings.asset";
+        }
+
+        public static HybridCLRSettings LoadOrCreate()
+        {
+            string filePath = GetFilePath();
+            Object[] objs = InternalEditorUtility.LoadSerializedFileAndForget(filePath);
+            s_Instance = objs.Length > 0 ? (HybridCLRSettings)objs[0] : (s_Instance ?? CreateInstance<HybridCLRSettings>());
+            return s_Instance;
+        }
+
+        public static void Save()
+        {
+            if (!s_Instance)
+            {
+                return;
+            }
+
+            string filePath = GetFilePath();
+            string directoryName = Path.GetDirectoryName(filePath);
+            Directory.CreateDirectory(directoryName);
+            var obj = new Object[1] { s_Instance };
+            InternalEditorUtility.SaveToSerializedFileAndForget(obj, filePath, true);
+        }
     }
 }