Skip to content

Commit e75bc61

Browse files
authored
Merge pull request #297 from kdambekalns/bugfix/296-return-type
BUGFIX: Correct return type declaration for deleteDuplicateDocumentNotMatchingType
2 parents a506246 + 1dd4c55 commit e75bc61

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Classes/Driver/DocumentDriverInterface.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ interface DocumentDriverInterface
3333
public function delete(NodeInterface $node, string $identifier): array;
3434

3535
/**
36-
* Generate the query to delete Elastic Document by Document Identifier but skip Document with the same Node Type
36+
* Delete documents by $documentIdentifier not having the given $nodeType
3737
*
3838
* @param Index $index
3939
* @param string $documentIdentifier
4040
* @param NodeType $nodeType
41-
* @return array
41+
* @return void
4242
*/
43-
public function deleteDuplicateDocumentNotMatchingType(Index $index, string $documentIdentifier, NodeType $nodeType): array;
43+
public function deleteDuplicateDocumentNotMatchingType(Index $index, string $documentIdentifier, NodeType $nodeType): void;
4444
}

Classes/Driver/Version5/DocumentDriver.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public function delete(NodeInterface $node, string $identifier): array
5454
* {@inheritdoc}
5555
* @throws \Flowpack\ElasticSearch\Exception
5656
*/
57-
public function deleteDuplicateDocumentNotMatchingType(Index $index, string $documentIdentifier, NodeType $nodeType): array
57+
public function deleteDuplicateDocumentNotMatchingType(Index $index, string $documentIdentifier, NodeType $nodeType): void
5858
{
5959
$result = $index->request('GET', '/_search?scroll=1m', [], json_encode([
6060
'sort' => ['_doc'],

0 commit comments

Comments
 (0)