TASK: Do not fail if the resource could not be fetched

Author: daniellienert

Classes/AssetExtraction/IngestAttachmentAssetExtractor.php

@@ -13,10 +13,11 @@
  * source code.
  */
 
-use Neos\Flow\Annotations as FLow;
+use Neos\Flow\Annotations as Flow;
 use Neos\ContentRepository\Search\AssetExtraction\AssetExtractorInterface;
 use Neos\ContentRepository\Search\Dto\AssetContent;
 use Flowpack\ElasticSearch\ContentRepositoryAdaptor\ElasticSearchClient;
+use Neos\Flow\Log\ThrowableStorageInterface;
 use Neos\Flow\Log\Utility\LogEnvironment;
 use Neos\Media\Domain\Model\AssetInterface;
 use Neos\Utility\Arrays;
@@ -33,6 +34,12 @@ class IngestAttachmentAssetExtractor implements AssetExtractorInterface
      */
     protected $elasticsearchClient;
 
+    /**
+     * @Flow\Inject
+     * @var ThrowableStorageInterface
+     */
+    protected $throwableStorage;
+
     /**
      * @Flow\Inject
      * @var LoggerInterface
@@ -105,10 +112,16 @@ public function extract(AssetInterface $asset): AssetContent
      */
     protected function getAssetContent(AssetInterface $asset): string
     {
-        $stream = $asset->getResource()->getStream();
+        try {
+            $stream = $asset->getResource()->getStream();
+        } catch (\Exception $e) {
+            $message = $this->throwableStorage->logThrowable($e);
+            $this->logger->error(sprintf('An exception occured while fetching resource with sah1 %s of asset %s. %s', $asset->getResource()->getSha1(), $asset->getResource()->getFilename(), $message), LogEnvironment::fromMethodName(__METHOD__));
+            return '';
+        }
 
         if ($stream === false) {
-            $this->logger->error(sprintf('Could not get the file stream of resource with sah1 %s of asset %s.', $asset->getResource()->getSha1(), $asset->getTitle()), LogEnvironment::fromMethodName(__METHOD__));
+            $this->logger->error(sprintf('Could not get the file stream of resource with sah1 %s of asset %s.', $asset->getResource()->getSha1(), $asset->getResource()->getFilename()), LogEnvironment::fromMethodName(__METHOD__));
             return '';
         }