Merge pull request #365 from daniellienert/bugfix/correctly-convert-dimension-json

daniellienert · web-flow · commit 5e5e1c0ca916 · 2021-01-26T16:13:06.000+01:00
BUGFIX: Correctly merge dimension json
diff --git a/Classes/Command/SearchCommandController.php b/Classes/Command/SearchCommandController.php
@@ -104,7 +104,7 @@ public function fulltextCommand(string $searchWord, string $path = '/', ?string
      */
     public function viewNodeCommand(string $identifier, ?string $dimensions = null, string $field = ''): void
     {
-        if ($dimensions !== null && is_array(json_decode($dimensions)) === false) {
+        if ($dimensions !== null && is_array(json_decode($dimensions, true, 512, JSON_THROW_ON_ERROR)) === false) {
             $this->outputLine('<error>Error: </error>The Dimensions must be given as a JSON array like \'{"language":["de"]}\'');
             $this->sendAndExit(1);
         }

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ public function fulltextCommand(string $searchWord, string $path = '/', ?string`
`104`	`104`	`*/`
`105`	`105`	`public function viewNodeCommand(string $identifier, ?string $dimensions = null, string $field = ''): void`
`106`	`106`	`{`
`107`		`- if ($dimensions !== null && is_array(json_decode($dimensions)) === false) {`
	`107`	`+ if ($dimensions !== null && is_array(json_decode($dimensions, true, 512, JSON_THROW_ON_ERROR)) === false) {`
`108`	`108`	`$this->outputLine('<error>Error: </error>The Dimensions must be given as a JSON array like \'{"language":["de"]}\'');`
`109`	`109`	`$this->sendAndExit(1);`
`110`	`110`	`}`