Merge pull request #132 from Flowpack/analysis-8PGQvW

TASK: Apply fixes from StyleCI

Author: kdambekalns

Classes/Flowpack/ElasticSearch/ContentRepositoryAdaptor/Eel/ElasticSearchQueryResult.php

@@ -255,4 +255,3 @@ public function allowsCallOfMethod($methodName)
         return true;
     }
 }
-

Classes/Flowpack/ElasticSearch/ContentRepositoryAdaptor/Indexer/NodeIndexer.php

@@ -137,7 +137,6 @@ public function getIndex()
     public function indexNode(NodeInterface $node, $targetWorkspaceName = null)
     {
         $indexer = function (NodeInterface $node, $targetWorkspaceName = null) {
-
             $contextPath = $node->getContextPath();
 
             if ($this->settings['indexAllWorkspaces'] === false) {
@@ -164,7 +163,7 @@ public function indexNode(NodeInterface $node, $targetWorkspaceName = null)
             $mappingType = $this->getIndex()->findType(NodeTypeMappingBuilder::convertNodeTypeNameToMappingName($nodeType));
 
             // Remove document with the same contextPathHash but different NodeType, required after NodeType change
-            $this->logger->log(sprintf('NodeIndexer: Removing node %s from index (if node type changed from %s). ID: %s', $contextPath, $node->getNodeType()->getName(), $contextPathHash), LOG_DEBUG, NULL, 'ElasticSearch (CR)');
+            $this->logger->log(sprintf('NodeIndexer: Removing node %s from index (if node type changed from %s). ID: %s', $contextPath, $node->getNodeType()->getName(), $contextPathHash), LOG_DEBUG, null, 'ElasticSearch (CR)');
             $this->getIndex()->request('DELETE', '/_query', array(), json_encode([
                 'query' => [
                     'bool' => [
@@ -273,11 +272,10 @@ public function indexNode(NodeInterface $node, $targetWorkspaceName = null)
         } else {
             $context = $this->contextFactory->create(array('workspaceName' => $workspaceName));
             $node = $context->getNodeByIdentifier($nodeIdentifier);
-            if ($node !== NULL) {
+            if ($node !== null) {
                 $indexer($node, $targetWorkspaceName);
             }
         }
-
     }
 
     /**

Classes/Flowpack/ElasticSearch/ContentRepositoryAdaptor/ViewHelpers/GetHitArrayForNodeViewHelper.php

@@ -45,7 +45,7 @@ class GetHitArrayForNodeViewHelper extends AbstractViewHelper
      * @param array|string $path
      * @return array
      */
-    public function render(ElasticSearchQueryResult $queryResultObject, NodeInterface $node, $path = NULL)
+    public function render(ElasticSearchQueryResult $queryResultObject, NodeInterface $node, $path = null)
     {
         $hitArray = $queryResultObject->searchHitForNode($node);
 

Tests/Unit/Eel/ElasticSearchQueryBuilderResultTest.php

@@ -42,4 +42,4 @@ public function ifNoAggregationsAreSetInTheQueyBuilderResultAnEmptyArrayWillBeRe
         $this->assertTrue(is_array($actual));
         $this->assertEmpty($actual);
     }
-}
+}

Tests/Unit/ViewHelpers/GetHitArrayForNodeViewHelperTest.php

@@ -104,4 +104,4 @@ public function aSingleValueWillBeReturnedForADottedPath()
         $fullResult = $this->viewHelper->render($this->mockQueryResult, $this->mockNode, 'sort');
         $this->assertEquals($hitArray['sort'], $fullResult, 'Full array will be returned if there are multiple values');
     }
-}
+}