TASK: Refactor nodeTypeMappingBuilder::convertNodeTypeNameToMappingName (#250)

daniellienert · web-flow · commit 30bcefff1bbb · 2018-04-19T12:14:51.000+02:00
Refactor the static method nodeTypeMappingBuilder::convertNodeTypeNameToMappingName to non-static.
This is needed as the nodeTypeMappingBuilder is now a configurable and injected object
which can be driver specific
diff --git a/Classes/Driver/AbstractNodeTypeMappingBuilder.php b/Classes/Driver/AbstractNodeTypeMappingBuilder.php
@@ -66,7 +66,7 @@ public function initializeObject($cause)
      * @param string $nodeTypeName
      * @return string
      */
-    public static function convertNodeTypeNameToMappingName($nodeTypeName)
+    public function convertNodeTypeNameToMappingName($nodeTypeName)
     {
         return str_replace('.', '-', $nodeTypeName);
     }
diff --git a/Classes/Driver/NodeTypeMappingBuilderInterface.php b/Classes/Driver/NodeTypeMappingBuilderInterface.php
@@ -27,7 +27,7 @@ interface NodeTypeMappingBuilderInterface
      * @param string $nodeTypeName
      * @return string
      */
-    public static function convertNodeTypeNameToMappingName($nodeTypeName);
+    public function convertNodeTypeNameToMappingName($nodeTypeName);
 
     /**
      * Builds a Mapping Collection from the configured node types
diff --git a/Classes/Driver/Version1/DocumentDriver.php b/Classes/Driver/Version1/DocumentDriver.php
@@ -38,11 +38,10 @@ class DocumentDriver extends AbstractDriver implements DocumentDriverInterface
      */
     public function delete(NodeInterface $node, $identifier)
     {
-        $nodeTypeMappingBuilder = $this->nodeTypeMappingBuilder;
         return [
             [
                 'delete' => [
-                    '_type' => $nodeTypeMappingBuilder::convertNodeTypeNameToMappingName($node->getNodeType()),
+                    '_type' => $this->nodeTypeMappingBuilder->convertNodeTypeNameToMappingName($node->getNodeType()),
                     '_id' => $identifier
                 ]
             ]
@@ -54,8 +53,6 @@ public function delete(NodeInterface $node, $identifier)
      */
     public function deleteDuplicateDocumentNotMatchingType(Index $index, $documentIdentifier, NodeType $nodeType)
     {
-        $nodeTypeMappingBuilder = $this->nodeTypeMappingBuilder;
-
         $index->request('DELETE', '/_query', [], json_encode([
             'query' => [
                 'bool' => [
@@ -66,7 +63,7 @@ public function deleteDuplicateDocumentNotMatchingType(Index $index, $documentId
                     ],
                     'must_not' => [
                         'term' => [
-                            '_type' => $nodeTypeMappingBuilder::convertNodeTypeNameToMappingName($nodeType->getName())
+                            '_type' => $this->nodeTypeMappingBuilder->convertNodeTypeNameToMappingName($nodeType->getName())
                         ]
                     ],
                 ]
diff --git a/Classes/Driver/Version1/IndexerDriver.php b/Classes/Driver/Version1/IndexerDriver.php
@@ -108,11 +108,10 @@ public function fulltext(NodeInterface $node, array $fulltextIndexOfNode, $targe
 
         $this->logger->log(sprintf('NodeIndexer (%s): Updated fulltext index for %s (%s)', $closestFulltextNodeDocumentIdentifier, $closestFulltextNodeContextPath, $closestFulltextNode->getIdentifier()), LOG_DEBUG, null, 'ElasticSearch (CR)');
 
-        $nodeTypeMappingBuilder = $this->nodeTypeMappingBuilder;
         return [
             [
                 'update' => [
-                    '_type' => $nodeTypeMappingBuilder::convertNodeTypeNameToMappingName($closestFulltextNode->getNodeType()->getName()),
+                    '_type' => $this->nodeTypeMappingBuilder->convertNodeTypeNameToMappingName($closestFulltextNode->getNodeType()->getName()),
                     '_id' => $closestFulltextNodeDocumentIdentifier
                 ]
             ],
diff --git a/Classes/Driver/Version1/Mapping/NodeTypeMappingBuilder.php b/Classes/Driver/Version1/Mapping/NodeTypeMappingBuilder.php
@@ -45,7 +45,7 @@ public function buildMappingInformation(Index $index)
                 continue;
             }
 
-            $type = $index->findType(self::convertNodeTypeNameToMappingName($nodeTypeName));
+            $type = $index->findType($this->convertNodeTypeNameToMappingName($nodeTypeName));
             $mapping = new Mapping($type);
             $fullConfiguration = $nodeType->getFullConfiguration();
             if (isset($fullConfiguration['search']['elasticSearchMapping'])) {
diff --git a/Classes/Driver/Version2/DocumentDriver.php b/Classes/Driver/Version2/DocumentDriver.php
@@ -35,8 +35,6 @@ class DocumentDriver extends Version1\DocumentDriver
      */
     public function deleteDuplicateDocumentNotMatchingType(Index $index, $documentIdentifier, NodeType $nodeType)
     {
-        $nodeTypeMappingBuilder = $this->nodeTypeMappingBuilder;
-
         $result = $index->request('GET', '/_search?scroll=1m', [], json_encode([
             'sort' => ['_doc'],
             'query' => [
@@ -48,7 +46,7 @@ public function deleteDuplicateDocumentNotMatchingType(Index $index, $documentId
                     ],
                     'must_not' => [
                         'term' => [
-                            '_type' => $nodeTypeMappingBuilder::convertNodeTypeNameToMappingName($nodeType->getName())
+                            '_type' => $this->nodeTypeMappingBuilder->convertNodeTypeNameToMappingName($nodeType->getName())
                         ]
                     ]
                 ]
diff --git a/Classes/Driver/Version2/IndexerDriver.php b/Classes/Driver/Version2/IndexerDriver.php
@@ -116,11 +116,10 @@ public function fulltext(NodeInterface $node, array $fulltextIndexOfNode, $targe
             $upsertFulltextParts[$node->getIdentifier()] = $fulltextIndexOfNode;
         }
 
-        $nodeTypeMappingBuilder = $this->nodeTypeMappingBuilder;
         return [
             [
                 'update' => [
-                    '_type' => $nodeTypeMappingBuilder::convertNodeTypeNameToMappingName($closestFulltextNode->getNodeType()->getName()),
+                    '_type' => $this->nodeTypeMappingBuilder->convertNodeTypeNameToMappingName($closestFulltextNode->getNodeType()->getName()),
                     '_id' => $closestFulltextNodeDocumentIdentifier
                 ]
             ],
diff --git a/Classes/Driver/Version5/IndexerDriver.php b/Classes/Driver/Version5/IndexerDriver.php
@@ -112,7 +112,7 @@ public function fulltext(NodeInterface $node, array $fulltextIndexOfNode, $targe
         return [
             [
                 'update' => [
-                    '_type' => AbstractNodeTypeMappingBuilder::convertNodeTypeNameToMappingName($closestFulltextNode->getNodeType()->getName()),
+                    '_type' => $this->nodeTypeMappingBuilder->convertNodeTypeNameToMappingName($closestFulltextNode->getNodeType()->getName()),
                     '_id' => $closestFulltextNodeDocumentIdentifier
                 ]
             ],
diff --git a/Classes/Driver/Version5/Mapping/NodeTypeMappingBuilder.php b/Classes/Driver/Version5/Mapping/NodeTypeMappingBuilder.php
@@ -59,7 +59,7 @@ public function buildMappingInformation(Index $index)
                 continue;
             }
 
-            $type = $index->findType(self::convertNodeTypeNameToMappingName($nodeTypeName));
+            $type = $index->findType($this->convertNodeTypeNameToMappingName($nodeTypeName));
             $mapping = new Mapping($type);
             $fullConfiguration = $nodeType->getFullConfiguration();
             if (isset($fullConfiguration['search']['elasticSearchMapping'])) {
diff --git a/Classes/Indexer/NodeIndexer.php b/Classes/Indexer/NodeIndexer.php
@@ -190,8 +190,7 @@ public function indexNode(NodeInterface $node, $targetWorkspaceName = null)
             $documentIdentifier = $this->calculateDocumentIdentifier($node, $targetWorkspaceName);
             $nodeType = $node->getNodeType();
 
-            $nodeTypeMappingBuilder = $this->nodeTypeMappingBuilder;
-            $mappingType = $this->getIndex()->findType($nodeTypeMappingBuilder::convertNodeTypeNameToMappingName($nodeType));
+            $mappingType = $this->getIndex()->findType($this->nodeTypeMappingBuilder->convertNodeTypeNameToMappingName($nodeType));
 
             if ($this->bulkProcessing === false) {
                 // Remove document with the same contextPathHash but different NodeType, required after NodeType change

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ public function initializeObject($cause)`
`66`	`66`	`* @param string $nodeTypeName`
`67`	`67`	`* @return string`
`68`	`68`	`*/`
`69`		`- public static function convertNodeTypeNameToMappingName($nodeTypeName)`
	`69`	`+ public function convertNodeTypeNameToMappingName($nodeTypeName)`
`70`	`70`	`{`
`71`	`71`	`return str_replace('.', '-', $nodeTypeName);`
`72`	`72`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,11 +38,10 @@ class DocumentDriver extends AbstractDriver implements DocumentDriverInterface`
`38`	`38`	`*/`
`39`	`39`	`public function delete(NodeInterface $node, $identifier)`
`40`	`40`	`{`
`41`		`- $nodeTypeMappingBuilder = $this->nodeTypeMappingBuilder;`
`42`	`41`	`return [`
`43`	`42`	`[`
`44`	`43`	`'delete' => [`
`45`		`- '_type' => $nodeTypeMappingBuilder::convertNodeTypeNameToMappingName($node->getNodeType()),`
	`44`	`+ '_type' => $this->nodeTypeMappingBuilder->convertNodeTypeNameToMappingName($node->getNodeType()),`
`46`	`45`	`'_id' => $identifier`
`47`	`46`	`]`
`48`	`47`	`]`
`@@ -54,8 +53,6 @@ public function delete(NodeInterface $node, $identifier)`
`54`	`53`	`*/`
`55`	`54`	`public function deleteDuplicateDocumentNotMatchingType(Index $index, $documentIdentifier, NodeType $nodeType)`
`56`	`55`	`{`
`57`		`- $nodeTypeMappingBuilder = $this->nodeTypeMappingBuilder;`
`58`		`-`
`59`	`56`	`$index->request('DELETE', '/_query', [], json_encode([`
`60`	`57`	`'query' => [`
`61`	`58`	`'bool' => [`
`@@ -66,7 +63,7 @@ public function deleteDuplicateDocumentNotMatchingType(Index $index, $documentId`
`66`	`63`	`],`
`67`	`64`	`'must_not' => [`
`68`	`65`	`'term' => [`
`69`		`- '_type' => $nodeTypeMappingBuilder::convertNodeTypeNameToMappingName($nodeType->getName())`
	`66`	`+ '_type' => $this->nodeTypeMappingBuilder->convertNodeTypeNameToMappingName($nodeType->getName())`
`70`	`67`	`]`
`71`	`68`	`],`
`72`	`69`	`]`
Original file line number	Diff line number	Diff line change
`@@ -108,11 +108,10 @@ public function fulltext(NodeInterface $node, array $fulltextIndexOfNode, $targe`
`108`	`108`
`109`	`109`	`$this->logger->log(sprintf('NodeIndexer (%s): Updated fulltext index for %s (%s)', $closestFulltextNodeDocumentIdentifier, $closestFulltextNodeContextPath, $closestFulltextNode->getIdentifier()), LOG_DEBUG, null, 'ElasticSearch (CR)');`
`110`	`110`
`111`		`- $nodeTypeMappingBuilder = $this->nodeTypeMappingBuilder;`
`112`	`111`	`return [`
`113`	`112`	`[`
`114`	`113`	`'update' => [`
`115`		`- '_type' => $nodeTypeMappingBuilder::convertNodeTypeNameToMappingName($closestFulltextNode->getNodeType()->getName()),`
	`114`	`+ '_type' => $this->nodeTypeMappingBuilder->convertNodeTypeNameToMappingName($closestFulltextNode->getNodeType()->getName()),`
`116`	`115`	`'_id' => $closestFulltextNodeDocumentIdentifier`
`117`	`116`	`]`
`118`	`117`	`],`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public function buildMappingInformation(Index $index)`
`45`	`45`	`continue;`
`46`	`46`	`}`
`47`	`47`
`48`		`- $type = $index->findType(self::convertNodeTypeNameToMappingName($nodeTypeName));`
	`48`	`+ $type = $index->findType($this->convertNodeTypeNameToMappingName($nodeTypeName));`
`49`	`49`	`$mapping = new Mapping($type);`
`50`	`50`	`$fullConfiguration = $nodeType->getFullConfiguration();`
`51`	`51`	`if (isset($fullConfiguration['search']['elasticSearchMapping'])) {`
Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,6 @@ class DocumentDriver extends Version1\DocumentDriver`
`35`	`35`	`*/`
`36`	`36`	`public function deleteDuplicateDocumentNotMatchingType(Index $index, $documentIdentifier, NodeType $nodeType)`
`37`	`37`	`{`
`38`		`- $nodeTypeMappingBuilder = $this->nodeTypeMappingBuilder;`
`39`		`-`
`40`	`38`	`$result = $index->request('GET', '/_search?scroll=1m', [], json_encode([`
`41`	`39`	`'sort' => ['_doc'],`
`42`	`40`	`'query' => [`
`@@ -48,7 +46,7 @@ public function deleteDuplicateDocumentNotMatchingType(Index $index, $documentId`
`48`	`46`	`],`
`49`	`47`	`'must_not' => [`
`50`	`48`	`'term' => [`
`51`		`- '_type' => $nodeTypeMappingBuilder::convertNodeTypeNameToMappingName($nodeType->getName())`
	`49`	`+ '_type' => $this->nodeTypeMappingBuilder->convertNodeTypeNameToMappingName($nodeType->getName())`
`52`	`50`	`]`
`53`	`51`	`]`
`54`	`52`	`]`
Original file line number	Diff line number	Diff line change
`@@ -116,11 +116,10 @@ public function fulltext(NodeInterface $node, array $fulltextIndexOfNode, $targe`
`116`	`116`	`$upsertFulltextParts[$node->getIdentifier()] = $fulltextIndexOfNode;`
`117`	`117`	`}`
`118`	`118`
`119`		`- $nodeTypeMappingBuilder = $this->nodeTypeMappingBuilder;`
`120`	`119`	`return [`
`121`	`120`	`[`
`122`	`121`	`'update' => [`
`123`		`- '_type' => $nodeTypeMappingBuilder::convertNodeTypeNameToMappingName($closestFulltextNode->getNodeType()->getName()),`
	`122`	`+ '_type' => $this->nodeTypeMappingBuilder->convertNodeTypeNameToMappingName($closestFulltextNode->getNodeType()->getName()),`
`124`	`123`	`'_id' => $closestFulltextNodeDocumentIdentifier`
`125`	`124`	`]`
`126`	`125`	`],`
Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ public function fulltext(NodeInterface $node, array $fulltextIndexOfNode, $targe`
`112`	`112`	`return [`
`113`	`113`	`[`
`114`	`114`	`'update' => [`
`115`		`- '_type' => AbstractNodeTypeMappingBuilder::convertNodeTypeNameToMappingName($closestFulltextNode->getNodeType()->getName()),`
	`115`	`+ '_type' => $this->nodeTypeMappingBuilder->convertNodeTypeNameToMappingName($closestFulltextNode->getNodeType()->getName()),`
`116`	`116`	`'_id' => $closestFulltextNodeDocumentIdentifier`
`117`	`117`	`]`
`118`	`118`	`],`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public function buildMappingInformation(Index $index)`
`59`	`59`	`continue;`
`60`	`60`	`}`
`61`	`61`
`62`		`- $type = $index->findType(self::convertNodeTypeNameToMappingName($nodeTypeName));`
	`62`	`+ $type = $index->findType($this->convertNodeTypeNameToMappingName($nodeTypeName));`
`63`	`63`	`$mapping = new Mapping($type);`
`64`	`64`	`$fullConfiguration = $nodeType->getFullConfiguration();`
`65`	`65`	`if (isset($fullConfiguration['search']['elasticSearchMapping'])) {`