[BUGFIX] After changing NodeType, ES indexes contains two documents

In ES the ID property is unique inside a single document type. With the
current implementation, after a NodeType change, we create a new document
with the new NodeType, but the old one stay in the index.

This change solve the issue with a DELETE query to check is an other
document share the same _id before indexing new values.

Author: dfeyer

Classes/Flowpack/ElasticSearch/ContentRepositoryAdaptor/Indexer/NodeIndexer.php

@@ -129,6 +129,24 @@ public function indexNode(NodeInterface $node, $targetWorkspaceName = NULL) {
 
 		$mappingType = $this->getIndex()->findType(NodeTypeMappingBuilder::convertNodeTypeNameToMappingName($nodeType));
 
+		// Remove document with the same contextPathHash but different NodeType, required after NodeType change
+		$this->getIndex()->request('DELETE', '/_query', array(), json_encode([
+			'query' => [
+				'bool' => [
+					'must' => [
+						'ids' => [
+							'values' => [ $contextPathHash ]
+						]
+					],
+					'must_not' => [
+						'term' => [
+							'_type' => str_replace('.', '/', $node->getNodeType()->getName())
+						]
+					],
+				]
+			]
+		]));
+
 		if ($node->isRemoved()) {
 			// TODO: handle deletion from the fulltext index as well
 			$mappingType->deleteDocumentById($contextPathHash);