Make the calculateDocumentIdentifier method public and static

we want to use that in other places as well to stay DRY

Author: remuslazar

Classes/Indexer/NodeIndexer.php

@@ -243,7 +243,7 @@ public function indexNode(NodeInterface $node, $targetWorkspaceName = null): voi
                 }
             }
 
-            $documentIdentifier = $this->calculateDocumentIdentifier($node, $targetWorkspaceName);
+            $documentIdentifier = NodeIndexer::calculateDocumentIdentifier($node, $targetWorkspaceName);
             $nodeType = $node->getNodeType();
 
             $mappingType = $this->getIndex()->findType($nodeType->getName());
@@ -346,11 +346,11 @@ protected function toBulkRequest(NodeInterface $node, array $requests = null): v
      * Returns a stable identifier for the Elasticsearch document representing the node
      *
      * @param NodeInterface $node
-     * @param string $targetWorkspaceName
+     * @param null $targetWorkspaceName
      * @return string
      * @throws IllegalObjectTypeException
      */
-    protected function calculateDocumentIdentifier(NodeInterface $node, $targetWorkspaceName = null): string
+    public static function calculateDocumentIdentifier(NodeInterface $node, $targetWorkspaceName = null): string
     {
         $workspaceName = $targetWorkspaceName ?: $node->getWorkspace()->getName();
         $nodeIdentifier = $node->getIdentifier();
@@ -384,7 +384,7 @@ public function removeNode(NodeInterface $node, string $targetWorkspaceName = nu
             }
         }
 
-        $documentIdentifier = $this->calculateDocumentIdentifier($node, $targetWorkspaceName);
+        $documentIdentifier = NodeIndexer::calculateDocumentIdentifier($node, $targetWorkspaceName);
 
         $this->toBulkRequest($node, $this->documentDriver->delete($node, $documentIdentifier));
         $this->toBulkRequest($node, $this->indexerDriver->fulltext($node, [], $targetWorkspaceName));