Merge pull request #144 from Flowpack/139-getTotalItems-fix

BUGFIX: Correctly determine number of total search results

This fixes ElasticSearchQueryBuilder::getTotalItems() that was checking
a non-existing result index total to retrieve the number of search results.

Fixes: #139

Author: kitsunet

Classes/Flowpack/ElasticSearch/ContentRepositoryAdaptor/Eel/ElasticSearchQueryBuilder.php

@@ -608,9 +608,10 @@ public function log($message = null)
      */
     public function getTotalItems()
     {
-        if (array_key_exists('total', $this->result)) {
-            return (int)$this->result['total'];
+        if (isset($this->result['hits']['total'])) {
+            return (int)$this->result['hits']['total'];
         }
+        return 0;
     }
 
     /**

Tests/Unit/Eel/ElasticSearchQueryBuilderTest.php

@@ -353,6 +353,22 @@ public function existingRequestPropertiesCanBeOverridden()
         $this->assertEquals($expected, $actual['limit']);
     }
 
+    /**
+     * @test
+     */
+    public function getTotalItemsReturnsZeroByDefault()
+    {
+        $this->assertSame(0, $this->queryBuilder->getTotalItems());
+    }
+
+    /**
+     * @test
+     */
+    public function getTotalItemsReturnsTotalHitsIfItExists()
+    {
+        $this->inject($this->queryBuilder, 'result', ['hits' => ['total' => 123]]);
+        $this->assertSame(123, $this->queryBuilder->getTotalItems());
+    }
 
     /**
      * Test helper