Merge pull request #21 from Flowpack/image-bugfix

BUGFIX: thumbnails were not stored during rendering

Author: lauchgott

Classes/NodeRendering/NodeRenderer.php

@@ -88,18 +88,6 @@ class NodeRenderer
      */
     protected $contextFactory;
 
-    /**
-     * @Flow\Inject
-     * @var NodeDataRepository
-     */
-    protected $nodeDataRepository;
-
-    /**
-     * @Flow\Inject
-     * @var NodeFactory
-     */
-    protected $nodeFactory;
-
     /**
      * @Flow\Inject
      * @var ContentReleaseManager
@@ -146,6 +134,11 @@ public function render(ContentReleaseIdentifier $contentReleaseIdentifier, Conte
 
             try {
                 $this->renderDocumentNodeVariant($enumeratedNode, $contentReleaseIdentifier, $contentReleaseLogger);
+                // BUGFIX: Because rendering a document node can update Thumbnails and their connected Persistent Resource
+                // objects (= Doctrine Entities), we need to *persist* these changes. Otherwise, we will have broken
+                // images, which will re-appear once you open the page in the backend (because image URL generation
+                // is fully deterministic). This happened 12/2022 to us.
+                $this->persistenceManager->persistAll();
             } finally {
                 $removalSuccess = $this->redisRenderingQueue->removeRenderingJobFromReservedList($contentReleaseIdentifier, $enumeratedNode, $rendererIdentifier);
                 if ($removalSuccess === false) {