BUGFIX: only validate keys which are transferred before switching

Author: skurfuerst

Classes/ReleaseSwitch/Infrastructure/RedisReleaseSwitchService.php

@@ -54,13 +54,21 @@ public function switchContentRelease(RedisInstanceIdentifier $redisInstanceIdent
         }
 
         $redisKeyPostfixesForEachRelease = RedisKeyPostfixesForEachRelease::fromArray($this->redisKeyPostfixesForEachReleaseConfiguration);
+        $hasError = false;
         foreach ($redisKeyPostfixesForEachRelease->getRequiredKeys() as $requiredPostfix) {
-            $key = $this->redisKeyService->getRedisKeyForPostfix($contentReleaseIdentifier, $requiredPostfix->getRedisKeyPostfix());
-            if (!$redis->exists($key)) {
-                $contentReleaseLogger->error('Required redis key ' . $key . ' does not exist for release thus we do not switch.');
-                return;
+            if ($requiredPostfix->shouldTransfer()) {
+                $key = $this->redisKeyService->getRedisKeyForPostfix($contentReleaseIdentifier, $requiredPostfix->getRedisKeyPostfix());
+                if (!$redis->exists($key)) {
+                    $contentReleaseLogger->error('Required redis key ' . $key . ' does not exist for release thus we do not switch.');
+                    $hasError = true;
+                }
             }
         }
+        if ($hasError === true) {
+            $contentReleaseLogger->error('ABORTING directly before switch because final key validation failed.');
+            exit(1);
+            return;
+        }
 
         $redis->set('contentStore:current', $contentReleaseIdentifier->getIdentifier());
         $releaseMetadata = $this->redisContentReleaseService->fetchMetadataForContentRelease($contentReleaseIdentifier);