Skip to content

Commit 8b5f110

Browse files
committed
TASK: Show rendering error details in render_orchestrator output
This stops having to go through all individual worker outputs
1 parent 6b25d92 commit 8b5f110

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

Classes/NodeRendering/NodeRenderOrchestrator.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,10 +223,11 @@ public function renderContentRelease(ContentReleaseIdentifier $contentReleaseIde
223223
// This is to gain better visibility into all errors currently happening; and thus maybe being able to see
224224
// patterns among the errors.
225225
// We also do NOT start a new incremental release, as this would lead very likely to the same errors.
226-
$amountOfRenderingErrors = count($this->redisRenderingErrorManager->getRenderingErrors($contentReleaseIdentifier));
226+
$renderingErrors = $this->redisRenderingErrorManager->getRenderingErrors($contentReleaseIdentifier);
227+
$amountOfRenderingErrors = count($renderingErrors);
227228
if ($amountOfRenderingErrors > 0) {
228229
$this->redisContentReleaseService->setContentReleaseMetadata($contentReleaseIdentifier, $releaseMetadata->withStatus(NodeRenderingCompletionStatus::failed()), RedisInstanceIdentifier::primary());
229-
$contentReleaseLogger->error('In this iteration, there happened ' . $amountOfRenderingErrors . ' rendering errors. EXITING now, as there is no chance of completing the content release successfully.');
230+
$contentReleaseLogger->error('In this iteration, there happened ' . $amountOfRenderingErrors . ' rendering errors. EXITING now, as there is no chance of completing the content release successfully.', [$renderingErrors]);
230231
yield ExitEvent::createWithStatusCode(self::EXIT_ERRORSTATUSCODE_RENDERING_ERRORS);
231232
return;
232233
}

0 commit comments

Comments
 (0)