BUGFIX: add samples option to memory usage command to fix release size calculation

batabana · batabana · commit 2e31442504b0 · 2022-03-21T14:10:19.000+01:00
diff --git a/Classes/BackendUi/BackendUiDataService.php b/Classes/BackendUi/BackendUiDataService.php
@@ -105,7 +105,9 @@ private function calculateReleaseSize(RedisInstanceIdentifier $redisInstanceIden
         $size = 0;
 
         foreach ($allKeys as $key) {
-            $size += $redis->rawCommand('memory', 'usage', $key);
+            // We need to set the `samples` option to 0 here, as the default value is 5 and specifies the number of
+            // sampled nested values. With 0 all nested values are sampled.
+            $size += $redis->rawCommand('memory', 'usage', $key, 'samples', '0');
         }
 
         // bytes are returned, convert to megabytes

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,9 @@ private function calculateReleaseSize(RedisInstanceIdentifier $redisInstanceIden`
`105`	`105`	`$size = 0;`
`106`	`106`
`107`	`107`	`foreach ($allKeys as $key) {`
`108`		`- $size += $redis->rawCommand('memory', 'usage', $key);`
	`108`	+ // We need to set the `samples` option to 0 here, as the default value is 5 and specifies the number of
	`109`	`+ // sampled nested values. With 0 all nested values are sampled.`
	`110`	`+ $size += $redis->rawCommand('memory', 'usage', $key, 'samples', '0');`
`109`	`111`	`}`
`110`	`112`
`111`	`113`	`// bytes are returned, convert to megabytes`