Skip to content

Commit 305c963

Browse files
authored
Fixed PERCENT_RANK computation (#8972)
1 parent c9d6ad4 commit 305c963

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

src/dsql/WinNodes.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -259,12 +259,12 @@ dsc* PercentRankWinNode::winPass(thread_db* /*tdbb*/, jrd_req* request, SlidingW
259259
impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
260260
impure_value_ex* impureTemp = request->getImpure<impure_value_ex>(tempImpure);
261261

262-
const double partitionSize = window->getPartitionSize();
263-
const double divisor = (partitionSize - 1) * (impureTemp->vlux_count - 1);
262+
const double dividend = impureTemp->vlux_count - 1;
263+
const double divisor = window->getPartitionSize() - 1;
264264

265265
impureTemp->vlu_misc.vlu_double = divisor == 0 ?
266266
0 :
267-
1 / divisor;
267+
dividend / divisor;
268268

269269
return &impureTemp->vlu_desc;
270270
}

0 commit comments

Comments
 (0)