Skip to content

backend/providers package has zero test coverage #60

Description

@aadityat23

Problem

Neither backend/providers/base.py, backend/providers/registry.py, nor backend/providers/sec.py has a corresponding test file in backend/tests/. This is distinct from the registry-extensibility gap above — even the single-provider SECProvider's can_handle and retrieve methods, and the resolve_provider_tier name/metadata fallback logic in base.py, have no direct unit test today.

Why this matters

resolve_provider_tier in particular contains non-trivial string-matching logic (checking for "sec", "fred", "dbnomics", "model" substrings to infer an evidence tier) that would silently misclassify a new provider's tier if the matching rules were ever changed without a test to catch a regression.

Acceptance Criteria

  • test_provider_base.py covers resolve_provider_tier's tier-resolution logic across metadata-provided tiers, name-based fallback, and the default case

  • test_sec_provider.py covers SECProvider.can_handle and retrieve in isolation from the rest of the pipeline

  • Coverage for this package is confirmed via pytest --cov=providers (or equivalent) showing non-zero, meaningful coverage

  • Tests added where appropriate

Files likely to modify

finverify-terminal/backend/tests/test_provider_base.py
finverify-terminal/backend/tests/test_sec_provider.py

Skills required

Python, pytest

Estimated difficulty

2/5

Estimated effort

3–5 hours

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions