Review feedback

Author: Eeems

_test_image.sh

@@ -51,7 +51,7 @@ chronic dd if=/dev/zero of=test_htree.ext4 count=20 bs=1048576
 chronic mkfs.ext4 -g 1024 -b 1024 -O 64bit,dir_index test_htree.ext4
 sudo mount -t ext4 test_htree.ext4 "$tmp_dir"
 # shellcheck disable=SC2064
-trap "sudo umount;rmdir \"$tmp_dir\"" EXIT
+trap "sudo umount \"$tmp_dir\";rmdir \"$tmp_dir\"" EXIT
 sudo mkdir "$tmp_dir"/empty
 printf '%s\n' "$tmp_dir"/{1..200} | xargs sudo touch
 sudo umount "$tmp_dir"

test.py

@@ -211,14 +211,15 @@ def test_root_inode(volume: ext4.Volume):
                 _assert("isinstance(entry.hash, int)", lambda: entry.hash)  # pyright: ignore[reportAny]
                 _assert("isinstance(entry.block, int)", lambda: entry.block)  # pyright: ignore[reportAny]
 
-            first_entry = entries[0]
-            _assert("first_entry.hash >= 0", lambda: first_entry.hash)  # pyright: ignore[reportAny]
-            _assert("first_entry.block > 0", lambda: first_entry.block)  # pyright: ignore[reportAny]
-
-            block_io = ext4.BlockIO(volume.root)
-            block = block_io.blocks[first_entry.block]  # pyright: ignore[reportAny]
-            _assert("len(block) > 0", lambda: len(block))
-            _assert(f"len(block) == {volume.block_size}", lambda: len(block))
+            if entries:
+                first_entry = entries[0]
+                _assert("first_entry.hash >= 0", lambda: first_entry.hash)  # pyright: ignore[reportAny]
+                _assert("first_entry.block > 0", lambda: first_entry.block)  # pyright: ignore[reportAny]
+
+                block_io = ext4.BlockIO(volume.root)
+                block = block_io.blocks[first_entry.block]  # pyright: ignore[reportAny]
+                _assert("len(block) > 0", lambda: len(block))
+                _assert(f"len(block) == {volume.block_size}", lambda: len(block))
 
             dirent = ext4.DirectoryEntry2(volume.root, 0)
             _assert("dirent.rec_len > 0", lambda: dirent.rec_len)  # pyright: ignore[reportAny]