Skip to content

Commit 5ac3677

Browse files
authored
Fix baggage propagator flaky test (#11101)
fix flaky test drain metric collector singleton before each test remove flaky annotation remove flaky annotation Co-authored-by: jean-philippe.bempel <jean-philippe.bempel@datadoghq.com>
1 parent 5daca39 commit 5ac3677

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

dd-trace-core/src/test/java/datadog/trace/core/baggage/BaggagePropagatorTelemetryTest.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,25 @@
1111
import datadog.trace.api.Config;
1212
import datadog.trace.api.metrics.BaggageMetrics;
1313
import datadog.trace.api.telemetry.CoreMetricCollector;
14-
import datadog.trace.test.util.Flaky;
1514
import java.util.Collection;
1615
import java.util.Collections;
1716
import java.util.List;
1817
import java.util.Map;
1918
import java.util.stream.Collectors;
19+
import org.junit.jupiter.api.BeforeEach;
2020
import org.junit.jupiter.api.Test;
2121

2222
class BaggagePropagatorTelemetryTest {
2323

2424
private static final CarrierVisitor<Map<String, String>> MAP_VISITOR = Map::forEach;
2525

26+
@BeforeEach
27+
void setup() {
28+
// Drain any metrics accumulated by other tests
29+
CoreMetricCollector.getInstance().prepareMetrics();
30+
CoreMetricCollector.getInstance().drain();
31+
}
32+
2633
@Test
2734
void shouldDirectlyIncrementBaggageMetrics() {
2835
BaggageMetrics baggageMetrics = BaggageMetrics.getInstance();
@@ -68,7 +75,6 @@ void shouldIncrementTelemetryCounterWhenBaggageIsSuccessfullyExtracted() {
6875
assertTrue(baggageMetric.tags.contains("header_style:baggage"));
6976
}
7077

71-
@Flaky
7278
@Test
7379
void shouldDirectlyIncrementAllBaggageMetrics() {
7480
BaggageMetrics baggageMetrics = BaggageMetrics.getInstance();
@@ -122,7 +128,6 @@ void shouldDirectlyIncrementAllBaggageMetrics() {
122128
assertEquals(1, itemsTruncatedMetric.value.longValue());
123129
}
124130

125-
@Flaky
126131
@Test
127132
void shouldNotIncrementTelemetryCounterWhenBaggageExtractionFails() {
128133
Config config = mock(Config.class);

0 commit comments

Comments
 (0)