implemented reverb. All effects now have getters and setters for drygain and wetgain, and the actual nodes have been renamed dryGainNode and wetGainNode

Author: gSkinner-Blair

src/effects/BiquadFilter.js

@@ -67,7 +67,7 @@ export default class BiquadFilter extends Effect {
 		this.detune = detune;
 
 		this.effectBus.connect(this.filterNode);
-		this.filterNode.connect(this.wetGain);
+		this.filterNode.connect(this.wetGainNode);
 	}
 }
 

src/effects/Effect.js

@@ -1,6 +1,23 @@
 import Sound from "../Sound"
 
 export default class Effect {
+
+	set dryGain(val) {
+		this.dryGainNode.gain.value = val;
+	}
+
+	get dryGain() {
+		return this.dryGainNode.gain.value;
+	}
+
+	set wetGain(val){
+		this.wetGainNode.gain.value = val;
+	}
+
+	get wetGain(){
+		return this.wetGainNode.gain.value;
+	}
+
 	constructor(){
 
 		// Set up the filter's internal audio graph here. At minimum, all filters need an input node and an output node
@@ -9,16 +26,16 @@ export default class Effect {
 		this.inputNode = Sound.context.createGain(); // The node external sources will connect to
 		this.effectBus = Sound.context.createGain(); // The node that connects up to the effects chain.
 		this.outputNode = Sound.context.createGain();// The node that will connect to external destinations
-		this.dryGain = Sound.context.createGain();		// The amount of dry signal included in the output
-		this.wetGain = Sound.context.createGain();   // The amount of wet signal included in the output
+		this.dryGainNode = Sound.context.createGain();		// The amount of dry signal included in the output
+		this.wetGainNode = Sound.context.createGain();   // The amount of wet signal included in the output
 
 		this.inputNode.connect(this.effectBus);
-		this.inputNode.connect(this.dryGain);
+		this.inputNode.connect(this.dryGainNode);
 
-		this.wetGain.connect(this.outputNode);
-		this.dryGain.connect(this.outputNode);
+		this.wetGainNode.connect(this.outputNode);
+		this.dryGainNode.connect(this.outputNode);
 
-		this.dryGain.gain.value = 0;
+		this.dryGainNode.gain.value = 0;
 
 		this._enabled = true;
 		this.owner = null; // The Sample, Playback or Group that owns this effect - used for checking when adding an effect to prevent being added to multiple locations
@@ -55,7 +72,7 @@ export default class Effect {
 		}
 
 		this.inputNode.disconnect(this.effectBus);
-		this.inputNode.disconnect(this.dryGain);
+		this.inputNode.disconnect(this.dryGainNode);
 		this.inputNode.connect(this.outputNode);
 		this._enabled = false;
 	}
@@ -67,7 +84,7 @@ export default class Effect {
 
 		this.inputNode.disconnect(this.outputNode);
 		this.inputNode.connect(this.effectBus);
-		this.inputNode.connect(this.dryGain);
+		this.inputNode.connect(this.dryGainNode);
 		this._enabled = true;
 	}
 }

src/effects/HighPassFilter.js

@@ -29,7 +29,7 @@ export default class HighPassFilter extends Effect {
 		this.Q = Q;
 
 		this.effectBus.connect(this.filterNode);
-		this.filterNode.connect(this.wetGain);
+		this.filterNode.connect(this.wetGainNode);
 	}
 
 

src/effects/LowPassFilter.js

@@ -29,7 +29,7 @@ export default class LowPassFilter extends Effect {
 		this.Q = Q;
 
 		this.effectBus.connect(this.filterNode);
-		this.filterNode.connect(this.wetGain);
+		this.filterNode.connect(this.wetGainNode);
 	}
 
 

src/effects/Reverb.js

@@ -0,0 +1,32 @@
+import Sound from "../Sound";
+import Effect from "./Effect"
+
+
+export default class Reverb extends Effect {
+
+	constructor(length = 1){
+		super();
+
+		this.reverbNode = Sound.context.createConvolver();
+		this.reverbNode.buffer = this.generateReverbSignal(length);
+
+		this.effectBus.connect(this.reverbNode);
+		this.reverbNode.connect(this.wetGainNode);
+	}
+
+	generateReverbSignal(length){
+		let bufferLength = length * createjs.Sound.context.sampleRate;
+		let numChannels = 1;
+		let buffer = createjs.Sound.context.createBuffer(numChannels, bufferLength, createjs.Sound.context.sampleRate );
+
+		let bufferData = buffer.getChannelData(0);
+		for(let i = 0; i < bufferData.length; i++){
+			bufferData[i] = (Math.random() * 2 - 1) * Math.pow((1 - (i/bufferData.length)),3);
+		}
+
+		this.buffer = buffer;
+		return buffer;
+
+	}
+
+}