From aeaa9c29e50cd2734c035133fc881ecdd9ccee32 Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Fri, 17 Jul 2026 03:23:58 +0000 Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=20Bolt:=20Hoist=20CSS=20and=20SHA-256?= =?UTF-8?q?=20generation=20out=20of=20process=5Fdir?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .jules/bolt.md | 3 +++ src/main/kotlin/html4tree/main.kt | 16 +++++++++------- src/test/kotlin/html4tree/CoverageTest.kt | 11 +++++++++++ 3 files changed, 23 insertions(+), 7 deletions(-) diff --git a/.jules/bolt.md b/.jules/bolt.md index 19b4c61..18abdbd 100644 --- a/.jules/bolt.md +++ b/.jules/bolt.md @@ -43,3 +43,6 @@ ## 2025-01-24 - 단일 readAttributes 호출로 파일 속성 조회 최적화 **학습:** `isDirectory`, `!it.isDirectory()`, `isSymbolicLink` 3개의 개별적인 파일 시스템 I/O 호출을 수행하면 성능 저하가 큽니다. 이를 단일 `Files.readAttributes` 호출로 변경하여 메타데이터를 한 번에 조회함으로써 I/O 오버헤드를 대폭 줄일 수 있음을 확인했습니다. **조치:** 디렉토리 순회 시 파일의 여러 속성을 확인할 때는 개별적인 stat 호출보다 `Files.readAttributes`를 사용하여 필요한 모든 속성을 한 번에 가져오는 방식을 우선적으로 고려해야 합니다. +## 2026-07-17 - Hoisting Cryptographic Hashes in Recursive Traversals +**Learning:** Computing cryptographic hashes (like SHA-256 for CSP style hashes) inside a recursive or frequently called function (like `process_dir`) introduces significant, redundant CPU overhead because the content is static across all invocations. +**Action:** Always hoist static cryptographic calculations and large string block allocations out of recursive or iterative paths to file-level constants (using `private val` in Kotlin to avoid getter generation overhead). diff --git a/src/main/kotlin/html4tree/main.kt b/src/main/kotlin/html4tree/main.kt index b455862..fa049a8 100644 --- a/src/main/kotlin/html4tree/main.kt +++ b/src/main/kotlin/html4tree/main.kt @@ -240,11 +240,9 @@ fun write_index_file(curr_dir: File, content: String) { } } -fun process_dir(curr_dir: File, excludeSet: Set? = null, dirFiles: Array? = null){ - - val exclude: Set = excludeSet ?: process_ignore_file(curr_dir) - - val cssContent = """ +// ⚡ Bolt Performance Optimization: Hoist static CSP style string blocks and expensive cryptographic SHA-256 hashes out of the hot recursive directory traversal path. +// Avoids generating getter methods by declaring as private val. +private val cssContent = """ body { font-family: system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", sans-serif; line-height: 1.5; @@ -310,13 +308,17 @@ fun process_dir(curr_dir: File, excludeSet: Set? = null, dirFiles: Array } """ - val styleHash = "sha256-" + Base64.getEncoder().encodeToString(MessageDigest.getInstance("SHA-256").digest(cssContent.toByteArray(Charsets.UTF_8))) +private val styleHash = "sha256-" + Base64.getEncoder().encodeToString(MessageDigest.getInstance("SHA-256").digest(cssContent.toByteArray(Charsets.UTF_8))) - val css = """ +private val css = """ """ +fun process_dir(curr_dir: File, excludeSet: Set? = null, dirFiles: Array? = null){ + + val exclude: Set = excludeSet ?: process_ignore_file(curr_dir) + val index_top = """ diff --git a/src/test/kotlin/html4tree/CoverageTest.kt b/src/test/kotlin/html4tree/CoverageTest.kt index dccf304..bb15112 100644 --- a/src/test/kotlin/html4tree/CoverageTest.kt +++ b/src/test/kotlin/html4tree/CoverageTest.kt @@ -19,4 +19,15 @@ class CoverageTest { readOnlyDir.setWritable(true, false) } } + + @Test + fun testCssContentProperties() { + val tempDir = java.nio.file.Files.createTempDirectory("test").toFile() + process_dir(tempDir) + val indexFile = File(tempDir, "index.html") + assertTrue(indexFile.exists()) + val content = indexFile.readText() + assertTrue(content.contains("sha256-")) + assertTrue(content.contains("