From 33c59adc50fa53f59a8eb9566485281f3a1fd5d0 Mon Sep 17 00:00:00 2001
From: seonghobae <8172694+seonghobae@users.noreply.github.com>
Date: Sat, 18 Jul 2026 16:23:27 +0000
Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=A1=EF=B8=8F=20Sentinel:=20[CRITICAL]?=
 =?UTF-8?q?=20`readline()`=20=EC=9E=85=EB=A0=A5=20=EC=A0=95=EA=B7=9C?=
 =?UTF-8?q?=EC=8B=9D=20=EA=B0=95=ED=99=94=EB=A1=9C=20DoS/=EA=B0=95?=
 =?UTF-8?q?=EC=A0=9C=20=ED=98=95=EB=B3=80=ED=99=98=20=EB=B0=A9=EC=A7=80?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- `aFIPC.R` 내의 `readline()` 입력 검증 로직에서 사용되던 느슨한 정규표현식(`^[0-9]+$`)을 엄격한 패턴(`^[12]$`)으로 변경하여 1 또는 2 외의 비정상적인 큰 숫자나 문자열 입력 시 발생할 수 있는 Integer coercion 에러 및 무한 루프(DoS) 취약점을 해결함.
- 관련된 보안 학습 내용을 `.jules/sentinel.md`에 추가함.
---
 .jules/sentinel.md | 5 +++++
 R/aFIPC.R          | 6 +++---
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/.jules/sentinel.md b/.jules/sentinel.md
index a8207a4..4bc620e 100644
--- a/.jules/sentinel.md
+++ b/.jules/sentinel.md
@@ -2,3 +2,8 @@
 **Vulnerability:** Unvalidated inputs passed to `if()` statements can cause process crashes (`condition has length > 1`) or unexpected coercion vulnerabilities.
 **Learning:** In R, optional boolean parameters that default to `NULL` should be validated using explicit runtime type validation (e.g., `if (!is.null(flag) && (!is.logical(flag) || length(flag) != 1 || is.na(flag)))`).
 **Prevention:** Always implement explicit runtime type validation for optional boolean parameters.
+
+## 2024-07-18 - [Weak regex check in `readline()` inputs causes Denial of Service]
+**Vulnerability:** The code used weak regex like `^[0-9]+$` for boolean-like choices via `readline()`, which allowed users to enter huge strings or numbers that evaluate out-of-bounds in R, resulting in an unhandled exception or integer coercion failure.
+**Learning:** `readline()` inputs in automated/interactive scripts require strict length/value matching rather than open-ended string matching. `^[0-9]+$` on a prompt that only accepts '1' or '2' is too permissive.
+**Prevention:** Use strictly bounded matching like `^[12]$` when only specific inputs are acceptable.
diff --git a/R/aFIPC.R b/R/aFIPC.R
index 6254651..918e19b 100644
--- a/R/aFIPC.R
+++ b/R/aFIPC.R
@@ -141,7 +141,7 @@ autoFIPC <-
       }
       for (attempt in seq_len(3)) {
         n <- readline(prompt = "Is it correct? (1: Yes 2: No) : ")
-        if (grepl("^[0-9]+$", n)) {
+        if (grepl("^[12]$", n)) {
           return(as.integer(n))
         }
       }
@@ -171,7 +171,7 @@ autoFIPC <-
               readline(
                 prompt = "Do you want to use default BILOG-MG priors for oldform Data? (1: Yes 2: No) : "
               )
-            if (grepl("^[0-9]+$", n)) {
+            if (grepl("^[12]$", n)) {
               return(as.integer(n))
             }
           }
@@ -390,7 +390,7 @@ autoFIPC <-
               readline(
                 prompt = "Do you want to use default BILOG-MG priors for newform Data? (1: Yes 2: No) : "
               )
-            if (grepl("^[0-9]+$", n)) {
+            if (grepl("^[12]$", n)) {
               return(as.integer(n))
             }
           }