Skip to content

Commit e35c95d

Browse files
seonghobaepr-auto-rebase[bot]
authored andcommitted
fix(strix): reject empty GitHub Models endpoint
1 parent 22e87ab commit e35c95d

2 files changed

Lines changed: 27 additions & 0 deletions

File tree

scripts/ci/strix_quick_gate.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2278,6 +2278,10 @@ resolved_llm_api_base_for_model() {
22782278
llm_api_base_value="${llm_api_base_value%%:generateContent*}"
22792279
llm_api_base_value="$(trim_whitespace "$llm_api_base_value")"
22802280
if [ -z "$llm_api_base_value" ]; then
2281+
if is_github_models_model "$model"; then
2282+
echo "ERROR: GitHub Models Strix scans require a non-empty LLM_API_BASE_FILE selecting the pinned GitHub Models inference endpoint." >&2
2283+
return 2
2284+
fi
22812285
return 0
22822286
fi
22832287
if [[ "$llm_api_base_value" =~ [[:space:][:cntrl:]] ]]; then

scripts/ci/test_strix_quick_gate.sh

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5773,6 +5773,18 @@ run_filtered_gate_case_if_requested() {
57735773
"" \
57745774
"https://attacker.invalid/v1"
57755775
;;
5776+
github-models-empty-api-base-file-rejected)
5777+
run_gate_case "github-models-empty-api-base-file-rejected" \
5778+
"openai/gpt-5" \
5779+
"" \
5780+
"2" \
5781+
"GitHub Models Strix scans require a non-empty LLM_API_BASE_FILE" \
5782+
"0" \
5783+
"" \
5784+
"" \
5785+
"openai" \
5786+
" "
5787+
;;
57765788
notfound-high-log-low-artifact)
57775789
run_gate_case "notfound-high-log-low-artifact" \
57785790
"vertex_ai/notfound-high-log-low-primary" \
@@ -11755,6 +11767,17 @@ run_gate_case "github-models-openai-gpt-requires-api-base" \
1175511767
"openai" \
1175611768
""
1175711769

11770+
run_gate_case "github-models-empty-api-base-file-rejected" \
11771+
"openai/gpt-5" \
11772+
"" \
11773+
"2" \
11774+
"GitHub Models Strix scans require a non-empty LLM_API_BASE_FILE" \
11775+
"0" \
11776+
"" \
11777+
"" \
11778+
"openai" \
11779+
" "
11780+
1175811781
run_gate_case "direct-openai-gpt-does-not-require-github-models-api-base" \
1175911782
"openai_direct/gpt-5.4" \
1176011783
"" \

0 commit comments

Comments
 (0)