shillinq PurchaseOrder schema composes decidesk's Order (`all_of: ["1585"]`) — PO creation is broken live

[rubenvdlinde]

Found while live-verifying FoldIntoOrder (#503). No PurchaseOrder object can be created on the live instance at all.

Symptom

saveObject(register: 'shillinq', schema: 'PurchaseOrder', ...)
=> The required properties (orderNumber, orderDate, orderStatus, totalPrice) are missing.

Those are not PurchaseOrder's required properties. Shillinq's PurchaseOrder (schema 1115) declares:

required = ["poNumber", "supplierId", "statusCode", "administrationId"]

Root cause

Schema 1115 carries:

all_of = ["1585"]

Schema 1585 is decidesk's order schema (slug=order, app=decidesk, title=Order), whose required set is exactly orderNumber, orderDate, orderStatus, totalPrice. So shillinq's PurchaseOrder composes another app's schema, and validation demands decidesk's fields.

Almost certainly a residue of the Order slug collision that #503 addressed by renaming shillinq's primitive to OrderPrimitive — the composition reference to 1585 was never unwound.

Impact

1. PurchaseOrder creation is broken on any instance where decidesk is installed alongside shillinq.
2. Cross-app coupling: a change to decidesk's order schema silently changes shillinq's PurchaseOrder validation.
3. Blocks fix(manifest): clear gate-53's structural stage (108→0) and gate-63 (ADR-079) — and surface the 152 findings hiding behind them #503. The FoldIntoOrder PurchaseOrder path cannot be live-verified, because no source row can be created. Two of three fold paths (Subsidie, DBAOpdracht) are proven in fix(repair): FoldIntoOrder was a silent no-op, then non-idempotent — 5 live-only defects #381; this one is not, and the migration stays HELD because of it.

Related: shillinq's register (#264) is also polluted with schema 1585 in its schemas[] array — same family of problem.

Suggested fix

Unwire all_of on 1115 (point it at shillinq's own primitive, or drop the composition), de-pollute register 264, then re-run the #503 live verification to prove the PurchaseOrder fold path and lift the HOLD.

⚠️ Verify whether existing PurchaseOrder rows depend on the inherited properties before changing the composition.

Refs #503, #381

[rubenvdlinde]

Investigated — this is dev-only corruption, not a production defect, and its root fix already landed one layer down.

Why it is dev-only

The all_of:["1585"] on shillinq's PurchaseOrder (1115) is a fossil of a rejected intermediate build that shipped allOf:["Order"]. On the shared 8080 instance (shillinq + decidesk on one OpenRegister), Order resolved case-insensitively / instance-wide to decidesk's live order schema (1585), and import union-merged decidesk's properties and required fields straight into 1115's own columns.

Two conditions had to both hold: the shared multi-app OR instance and that never-released build. Current shillinq source is clean — its only two allOf occurrences are inline constraint rules (a precondition field-rule and a JSON-Schema if/then), not cross-schema compositions. A clean production install never regenerates this fossil. There is nothing in production to heal.

Root fix is already merged, in the right place

The wider pattern (cross-app slug collision on a shared OpenRegister) is production-relevant, but the permanent fix belongs to OpenRegister, not shillinq — and it is openregister#2047, merged 2026-07-24 ("scope slug resolution by app/register — stop cross-app schema collisions").

Live remediation performed on 8080 (one-off, dev)

• Restored schema 1115 from source: properties/required reset, fossil all_of cleared.
• Removed 1585 from shillinq register Implement: Bank Reconciliation #264's schemas[] (503 → 502); decidesk register [L4] Obligation & Financial Administration — Shillinq #18 and schema 1585 untouched.
• Verified: a PurchaseOrder object now creates cleanly, and the FoldIntoOrder PurchaseOrder path folds correctly (cent→EUR conversion confirmed: 121000 → 1210.00), idempotent, sources + decidesk intact.

Recommendation

Close as dev-only, live-remediated. No shillinq repair step or guard is warranted (it would treat a dev symptom whose root is fixed by #2047). This unblocks #503 — its PurchaseOrder fold path is now proven.

Refs #503, openregister#2047