Clean up some lint warnings

Author: Jawnnypoo

adapterflowlayout/src/main/AndroidManifest.xml

@@ -1,6 +1,2 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-          package="com.commit451.adapterflowlayout">
-
-    <application />
-
-</manifest>
+          package="com.commit451.adapterflowlayout"/>

adapterflowlayout/src/main/java/com/commit451/adapterflowlayout/AdapterFlowLayout.java

@@ -11,6 +11,7 @@
 /**
  * {@link com.wefika.flowlayout.FlowLayout} with {@link android.support.v7.widget.RecyclerView.Adapter} support.
  */
+@SuppressWarnings("unused")
 public class AdapterFlowLayout extends FlowLayout {
 
     private AdapterLayoutDelegate adapterLayoutDelegate;

adapterlayout-kotlin/src/main/AndroidManifest.xml

@@ -1,6 +1 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="com.commit451.adapterlayout.kotlin">
-
-    <application />
-
-</manifest>
+<manifest package="com.commit451.adapterlayout.kotlin" />

adapterlayout-kotlin/src/main/java/com/commit451/adapterlayout/kotlin/kotlin.kt

@@ -1,3 +1,5 @@
+@file:Suppress("unused")
+
 package com.commit451.adapterlayout.kotlin
 
 import android.support.v7.widget.RecyclerView

adapterlayout/src/main/AndroidManifest.xml

@@ -1,5 +1 @@
-<manifest package="com.commit451.adapterlayout">
-
-    <application />
-
-</manifest>
+<manifest package="com.commit451.adapterlayout" />

adapterlayout/src/main/java/com/commit451/adapterlayout/AdapterLayoutDelegate.java

@@ -18,7 +18,7 @@ public class AdapterLayoutDelegate {
     /**
      * Checks for if the data changes and changes the views accordingly
      */
-    private RecyclerView.AdapterDataObserver mObserver = new RecyclerView.AdapterDataObserver() {
+    private RecyclerView.AdapterDataObserver observer = new RecyclerView.AdapterDataObserver() {
         @Override
         public void onChanged() {
             super.onChanged();
@@ -30,14 +30,14 @@ public void onChanged() {
         @Override
         public void onItemRangeChanged(int positionStart, int itemCount) {
             super.onItemRangeChanged(positionStart, itemCount);
-            updateViews(positionStart, itemCount, null);
+            updateViews(positionStart, itemCount);
             reindex();
         }
 
         @Override
         public void onItemRangeChanged(int positionStart, int itemCount, Object payload) {
             super.onItemRangeChanged(positionStart, itemCount, payload);
-            updateViews(positionStart, itemCount, payload);
+            updateViews(positionStart, itemCount);
             reindex();
         }
 
@@ -58,7 +58,7 @@ public void onItemRangeRemoved(int positionStart, int itemCount) {
         @Override
         public void onItemRangeMoved(int fromPosition, int toPosition, int itemCount) {
             super.onItemRangeMoved(fromPosition, toPosition, itemCount);
-            //TODO this should probably be smarter and just move relevant views
+            // this should probably be smarter and just move relevant views
             recreateViews();
             reindex();
         }
@@ -81,14 +81,14 @@ public AdapterLayoutDelegate(ViewGroup viewGroup) {
     public void setAdapter(@Nullable RecyclerView.Adapter adapter) {
         if (this.adapter != null) {
             try {
-                this.adapter.unregisterAdapterDataObserver(mObserver);
+                this.adapter.unregisterAdapterDataObserver(observer);
             } catch (Exception ignored) {
             }
         }
 
         this.adapter = adapter;
         if (this.adapter != null) {
-            this.adapter.registerAdapterDataObserver(mObserver);
+            this.adapter.registerAdapterDataObserver(observer);
         }
         recreateViews();
     }
@@ -135,13 +135,15 @@ private void addViewAt(int viewType, int index) {
         viewHolder.itemView.setTag(R.id.adapter_layout_list_view_type, viewType);
         viewHolder.itemView.setTag(R.id.adapter_layout_list_position, index);
         viewGroup.addView(viewHolder.itemView);
+        //noinspection unchecked
         adapter.onBindViewHolder(viewHolder, index);
     }
 
-    private void updateViews(int positionStart, int itemCount, @Nullable Object payload) {
+    private void updateViews(int positionStart, int itemCount) {
         final int end = positionStart + itemCount;
         for (int i = positionStart; i < end; i++) {
             RecyclerView.ViewHolder viewHolder = getViewHolderAt(i);
+            //noinspection unchecked
             adapter.onBindViewHolder(viewHolder, i);
         }
     }
@@ -170,6 +172,7 @@ private void recreateViews() {
 
                 if (savedViewType != null && savedViewType == viewType && savedViewHolder != null) {
                     //perfect, it exists and is the right type, so just bind it
+                    //noinspection unchecked
                     adapter.onBindViewHolder(savedViewHolder, i);
                 } else {
                     //it already existed, but something was wrong. So remove it and recreate it

adapterlayout/src/main/java/com/commit451/adapterlayout/AdapterLinearLayout.java

@@ -14,6 +14,7 @@
  * the good bits, and follow the convention here to create your own {@link android.support.v7.widget.RecyclerView.Adapter}
  * backed {@link android.view.ViewGroup}
  */
+@SuppressWarnings("unused")
 public class AdapterLinearLayout extends LinearLayout {
 
     private AdapterLayoutDelegate adapterLayoutDelegate;
@@ -43,6 +44,7 @@ public void setAdapter(RecyclerView.Adapter adapter) {
         adapterLayoutDelegate.setAdapter(adapter);
     }
 
+    @Nullable
     public RecyclerView.Adapter getAdapter() {
         if (adapterLayoutDelegate != null) {
             return adapterLayoutDelegate.getAdapter();

app/src/main/AndroidManifest.xml

@@ -16,7 +16,7 @@
             </intent-filter>
         </activity>
 
-        <activity android:name=".AdapterFlowLayoutActivity"/>
+        <activity android:name=".AdapterFlowLayoutActivity" />
     </application>
 
 </manifest>

build.gradle

@@ -1,15 +1,15 @@
 apply plugin: 'com.github.ben-manes.versions'
 buildscript {
-    ext.kotlinVersion = '1.2.21'
+    ext.kotlinVersion = '1.2.60'
     repositories {
         jcenter()
         google()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.0.1'
+        classpath 'com.android.tools.build:gradle:3.1.4'
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
-        classpath 'com.github.dcendents:android-maven-gradle-plugin:2.0'
-        classpath 'com.github.ben-manes:gradle-versions-plugin:0.17.0'
+        classpath 'com.github.dcendents:android-maven-gradle-plugin:2.1'
+        classpath 'com.github.ben-manes:gradle-versions-plugin:0.20.0'
     }
 }
 
@@ -28,5 +28,5 @@ ext {
     minSdkVersion = 15
     compileSdkVersion = 27
     targetSdkVersion = compileSdkVersion
-    supportLibVersion = '27.0.2'
+    supportLibVersion = '27.1.1'
 }

gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
-#Fri Sep 29 16:24:20 CDT 2017
+#Thu Aug 16 19:01:46 CDT 2018
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip