+
{label}
{required && * }
)}
{children}
- {hint && !error && (
- {hint}
- )}
+ {hint && !error && {hint}
}
{error && (
{error}
diff --git a/tests/e2e/issues-scope.spec.ts b/tests/e2e/issues-scope.spec.ts
new file mode 100644
index 00000000..e74d3716
--- /dev/null
+++ b/tests/e2e/issues-scope.spec.ts
@@ -0,0 +1,59 @@
+import { expect, test } from "@playwright/test";
+
+test("lifecycle scope stays consistent when switching between list and kanban", async ({
+ page,
+}) => {
+ await page.addInitScript(() => {
+ localStorage.setItem("forge:view:issues", "list");
+ });
+ await page.goto("/w/forge/issues");
+
+ const openScope = page.getByRole("button", { name: "open", exact: true });
+ const allScope = page.getByRole("button", { name: "all", exact: true });
+ const visibleCompletedIssue = page
+ .locator("a:visible")
+ .filter({ hasText: "Webhook delivery retry backoff" });
+ await expect(openScope).toHaveAttribute("aria-pressed", "true");
+
+ await page
+ .getByRole("textbox", { name: "Search open issues" })
+ .fill("Webhook delivery retry backoff");
+ await expect(page.getByText("No issues match this view")).toBeVisible();
+ await expect(page.getByText("Webhook delivery retry backoff", { exact: true })).toHaveCount(0);
+
+ await page.getByRole("button", { name: "Kanban", exact: true }).click();
+ await expect(page.getByText("No issues match this view")).toBeVisible();
+ await expect(page.getByText("Webhook delivery retry backoff", { exact: true })).toHaveCount(0);
+
+ await allScope.click();
+ await expect(page.getByRole("textbox", { name: "Search all issues" })).toBeVisible();
+ await expect(visibleCompletedIssue).toBeVisible();
+
+ await page.getByRole("button", { name: "List", exact: true }).click();
+ await expect(visibleCompletedIssue).toBeVisible();
+});
+
+test("project creation explains the key and recovers from validation", async ({ page }) => {
+ await page.goto("/w/forge/projects");
+ await page.getByRole("button", { name: "New project", exact: true }).click();
+
+ await expect(
+ page.getByText("Used in issue IDs, for example FRG-123. It cannot be changed later."),
+ ).toBeVisible();
+
+ const createProject = page.getByRole("button", { name: /^Create project/ });
+ await createProject.click();
+ const validationError = page.getByText("Name and key are required.", { exact: true });
+ await expect(validationError).toBeVisible();
+
+ const uniqueKey = `PW${Date.now().toString(36).slice(-5)}`.toUpperCase();
+ await page.getByLabel("Name").fill("Playwright lifecycle project");
+ await expect(validationError).toHaveCount(0);
+ await page.getByLabel("Key").fill(uniqueKey);
+ await createProject.click();
+
+ await expect(page).toHaveURL(/\/w\/forge\/projects\/[^/?]+$/);
+ await expect(
+ page.getByRole("heading", { name: "Playwright lifecycle project", exact: true }),
+ ).toBeVisible();
+});
diff --git a/tests/unit/saved-view-filters.test.ts b/tests/unit/saved-view-filters.test.ts
index 761e5b83..6e03b05a 100644
--- a/tests/unit/saved-view-filters.test.ts
+++ b/tests/unit/saved-view-filters.test.ts
@@ -3,6 +3,7 @@ import {
filtersEqual,
hasTerminalStatusCategory,
isEmptyFilters,
+ resolveIncludeDone,
safeParseFilters,
withIncludeDoneForTerminalFilters,
type SavedViewFilters,
@@ -39,9 +40,7 @@ describe("filtersEqual", () => {
});
it("returns false when array lengths differ", () => {
- expect(filtersEqual({ statusIds: ["x"] }, { statusIds: ["x", "y"] })).toBe(
- false,
- );
+ expect(filtersEqual({ statusIds: ["x"] }, { statusIds: ["x", "y"] })).toBe(false);
});
it("treats missing array and empty array as equal", () => {
@@ -51,9 +50,7 @@ describe("filtersEqual", () => {
it("compares scalar values strictly", () => {
expect(filtersEqual({ query: "foo" }, { query: "foo" })).toBe(true);
expect(filtersEqual({ query: "foo" }, { query: "bar" })).toBe(false);
- expect(filtersEqual({ updatedSince: "7d" }, { updatedSince: "1d" })).toBe(
- false,
- );
+ expect(filtersEqual({ updatedSince: "7d" }, { updatedSince: "1d" })).toBe(false);
});
});
@@ -83,4 +80,14 @@ describe("terminal status filter helpers", () => {
});
expect(filters.includeDone).toBe(true);
});
+
+ it("keeps the surface default authoritative until a terminal filter is explicit", () => {
+ const doneIds = new Set(["done-id", "canceled-id"]);
+ expect(resolveIncludeDone({}, false, doneIds)).toBe(false);
+ expect(resolveIncludeDone({}, true, doneIds)).toBe(true);
+ expect(resolveIncludeDone({ statusIds: ["done-id"] }, false, doneIds)).toBe(true);
+ expect(
+ resolveIncludeDone({ statusCategories: [StatusCategory.CANCELED] }, false, doneIds),
+ ).toBe(true);
+ });
});