London | 26-ITP-MAY | Khaliun Baatarkhuu | Sprint 1 | Form Controls #1431
Open
khaliun-dev wants to merge 6 commits into
Open
London | 26-ITP-MAY | Khaliun Baatarkhuu | Sprint 1 | Form Controls #1431khaliun-dev wants to merge 6 commits into
khaliun-dev wants to merge 6 commits into
Conversation
Added form fields for customer name and email with validation requirements.
Updated T-shirt size selection options and footer name.
Added CSS styles for form layout and elements.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
khaliun-dev
added
Needs Review
cjyuan
reviewed
Jun 8, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Form looks good. Code is well formatted and error free. Well done.
Can you address the comments left on the name input field?
Comment on lines
+55
to
+61
| <input | ||
| type="text" | ||
| id="name" | ||
| name="name" | ||
| pattern=".*\S{2,}.*" | ||
| required | ||
| /> |
Contributor
There was a problem hiding this comment.
-
When the user input is rejected, the browser shows "Please match the requested format" but it is not clear what the requested format is. Can you make it clearer to the user what format should a name be?
-
Should a name such as "C J" (with a space between two alphabets) be considered a name containing at least two non-space characters?
| <legend>Choose a Colour</legend> | ||
|
|
||
| <input type="radio" id="red" name="colour" value="red" required> | ||
| <label for="red">Red</label> |
Contributor
There was a problem hiding this comment.
Note: Here's is an alternate markup that does not involve "id" and "for" attributes.
<label>
<input type="radio" name="colour" value="red" required>
Red
</label>
Author
There was a problem hiding this comment.
Ok, understood. The input is inside the label attribute, making it easier to read and needing less code.
cjyuan
added
Reviewed
- Added "title" attribute to make it clearer for the user.
- Changed "pattern=".*\S{2,}.*" to "pattern=".*\S.*\S.*", because the former might not accept C J due to it being non consecutive.
khaliun-dev
added
the
Needs Review
Contributor
|
Changes look good. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Questions
None so far