Skip to content

bug in protobuf feature build for Windows #22

Description

@williballenthin

#14 introduces support for building the protobuf code on Windows, but I think its subtly broken: using target_os in build.rs reflects the OS of the host building the build script, not the final program. ref

So, this code should be updated: https://github.com/CerebusOSS/ella/blob/0343b4f54f1f81d093a27da79192ed9c468fffec/ella-server/build.rs#L2C1-L5C66

perhaps to if std::env::var_os(key: "CARGO_CFG_WINDOWS").is_some() {...} else {...}

I encountered this while trying to get my project to build prost/protobuf-src for Windows, and your work got me nearly the whole way there. Thank you!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions