Skip to content

Commit bc705a5

Browse files
Rongronggg91Naim
authored andcommitted
platform/x86: lenovo-wmi-helpers: Fix memory leak in lwmi_dev_evaluate_int()
lwmi_dev_evaluate_int() leaks output.pointer when retval == NULL (found by sashiko.dev [1]). Fix it by moving `ret_obj = output.pointer' outside of the `if (retval)' block so that it is always freed by the __free cleanup callback. No functional change intended. Fixes: e521d16 ("platform/x86: Add lenovo-wmi-helpers") Cc: stable@vger.kernel.org Link: https://sashiko.dev/#/patchset/20260331181208.421552-1-derekjohn.clark%40gmail.com [1] Signed-off-by: Rong Zhang <i@rong.moe>
1 parent 6de23f8 commit bc705a5

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/platform/x86/lenovo/wmi-helpers.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,9 @@ int lwmi_dev_evaluate_int(struct wmi_device *wdev, u8 instance, u32 method_id,
5555
if (ACPI_FAILURE(status))
5656
return -EIO;
5757

58+
ret_obj = output.pointer;
59+
5860
if (retval) {
59-
ret_obj = output.pointer;
6061
if (!ret_obj)
6162
return -ENODATA;
6263

0 commit comments

Comments
 (0)